Correctly account for CDK::Metadata resource in cdk diff`
#435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arguments to the diff function were passed incorrectly, resulting in the version tracking information not being forwarded correctly to synthesizeTemplate. Fixes #422
RomainMuller
requested review from
eladb and
rix0rrr
and removed request for
eladb
eladb
approved these changes
Jul 30, 2018
| const toolkitStackName = completeConfig().get(['toolkitStackName']) || DEFAULT_TOOLKIT_STACK_NAME; | ||
| const trackVersions = completeConfig().get(['versionReporting']); | ||
| const toolkitStackName: string = completeConfig().get(['toolkitStackName']) || DEFAULT_TOOLKIT_STACK_NAME; | ||
| const trackVersions: boolean = completeConfig().get(['versionReporting']); |
There was a problem hiding this comment.
What does this mean in terms of disabling version reporting via cdk.json? I think this should be:
{
"version-reporting": false
}And not versionReporting (I am okay with allowing both)
There was a problem hiding this comment.
Kebab-case (version-reporting) in the JSON feels... weird. Also, if version-reporting, then toolkit-stack-name.
Allowing both feels... messy (then we want to check if we got both at the same time, and err if they disagree with each other... feels like an un-necessary evil).
There was a problem hiding this comment.
Okay, let's leave it versionReporting (although I like my reservation to be recorded for posterity).
eladb
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arguments to the diff function were passed incorrectly, resulting in
the version tracking information not being forwarded correctly to
synthesizeTemplate.
Fixes #422
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.