Skip to content

Commit

Permalink
fix(codepipeline): Action.onStateChange() has wrong detail type (#5721)
Browse files Browse the repository at this point in the history
The method onStateChange() in Action,
the common superclass for all CDK-vended actions,
incorrectly set the `detailType` of the CloudWatch event rule it created to
'CodePipeline Stage Execution State Change',
when it should be 'CodePipeline Action Execution State Change'.

Fixes #3614

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
  • Loading branch information
skinny85 and mergify[bot] committed Jan 9, 2020
1 parent be2e3e3 commit 8686dd5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-codepipeline-actions/lib/action.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export abstract class Action implements codepipeline.IAction {
const rule = new events.Rule(this.scope, name, options);
rule.addTarget(target);
rule.addEventPattern({
detailType: [ 'CodePipeline Stage Execution State Change' ],
detailType: [ 'CodePipeline Action Execution State Change' ],
source: [ 'aws.codepipeline' ],
resources: [ this.pipeline.pipelineArn ],
detail: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@
"Properties": {
"EventPattern": {
"detail-type": [
"CodePipeline Stage Execution State Change"
"CodePipeline Action Execution State Change"
],
"source": [
"aws.codepipeline"
Expand Down

0 comments on commit 8686dd5

Please sign in to comment.