fix(codepipeline): Action.onStateChange() has wrong detail type #5721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
The method onStateChange() in Action, the common superclass for all CDK-vended actions, incorrectly set the `detailType` of the CloudWatch event rule it created to 'CodePipeline Stage Execution State Change', when it should be 'CodePipeline Action Execution State Change'. Fixes aws#3614
skinny85
force-pushed
the
fix/codepipeline-action-event-detail
branch
from
22de71e to
0107897
Compare
|
Changed to reference the correct issue in the commit message. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
approved these changes
Jan 9, 2020
|
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request is now being automatically merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
onStateChange()inAction, the common superclass for all CDK-vended actions,incorrectly set the
detailTypeof the CloudWatch event rule it created to'CodePipeline Stage Execution State Change',
when it should be 'CodePipeline Action Execution State Change'.
Fixes #3614
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license