-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: update contribution guide with feature flag support for v2 (#1…
…3084) Update how feature flags that are destined to be dropped in v2 should be developed. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information
Niranjan Jayakar
authored
Feb 16, 2021
1 parent
b984b19
commit ca08245
Showing
2 changed files
with
21 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,12 @@ | ||
import { testLegacyBehavior } from 'cdk-build-tools/lib/feature-flag'; | ||
import * as feats from '../lib/features'; | ||
|
||
test('all future flags have defaults configured', () => { | ||
Object.keys(feats.FUTURE_FLAGS).forEach(flag => { | ||
expect(typeof(feats.futureFlagDefault(flag))).toEqual('boolean'); | ||
}); | ||
}); | ||
|
||
testLegacyBehavior('FUTURE_FLAGS_EXPIRED must be empty in CDKv1', Object, () => { | ||
expect(feats.FUTURE_FLAGS_EXPIRED.length).toEqual(0); | ||
}); |