Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update contribution guide with feature flag support for v2 #13084

Merged
merged 4 commits into from
Feb 16, 2021

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Feb 16, 2021

Update how feature flags that are destined to be dropped in v2 should be
developed.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Update how feature flags that are destined to be dropped in v2 should be
developed.
@nija-at nija-at self-assigned this Feb 16, 2021
@gitpod-io
Copy link

gitpod-io bot commented Feb 16, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 16, 2021
@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Feb 16, 2021
@nija-at nija-at added pr/do-not-merge This PR should not be merged at this time. and removed pr/do-not-merge This PR should not be merged at this time. labels Feb 16, 2021
@nija-at nija-at removed the pr/do-not-merge This PR should not be merged at this time. label Feb 16, 2021
@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c67569c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ca08245 into master Feb 16, 2021
@mergify mergify bot deleted the nija-at/featureflag-contributionguide branch February 16, 2021 17:50
NovakGu pushed a commit to NovakGu/aws-cdk that referenced this pull request Feb 18, 2021
…s#13084)

Update how feature flags that are destined to be dropped in v2 should be
developed.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb pushed a commit that referenced this pull request Feb 22, 2021
…3084)

Update how feature flags that are destined to be dropped in v2 should be
developed.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants