-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] bootstrap upgrade to version 4 fails after upgrade from 1.60.0 to 1.61.0 #10016
Comments
Dug into this a little bit and it looks like the parameter it is looking for is incorrect:
I believe this should reference
That is assuming it is supposed to be referencing this resource from the bootstrap-template: aws-cdk/packages/aws-cdk/lib/api/bootstrap/bootstrap-template.yaml Lines 358 to 364 in 960ef12
|
Reproduced by doing the following:
Got the same error as reported in the ticket. I re-reran the bootstrap command with the |
It would be good to hear from a project owner if |
looking into it: minimal repro steps: Deploy bootstrap version 3
Upgrade & try to deploy bootstrap version 4
will result in:
|
We were reading the wrong key when reading version source for template resources. This prevented upgrade of bootstrap as the new version was being returned as `0` instead of `4`. Fixes #10016
We were reading the wrong key when reading version source for template resources. This prevented upgrade of bootstrap as the new version was being incorrectly returned as `0`. Fixes #10016 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
We were reading the wrong key when reading version source for template resources. This prevented upgrade of bootstrap as the new version was being incorrectly returned as `0`. Fixes #10016 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
patch to fix bootstrapping issue was released in 1.61.1 |
Tested and works just fine! Thanks for fix and also releasing so quickly, very much appreciated! 💯 |
@shivlaks this is still broken for me. Upgrading from
CLI and framework version is 1.61.1. EDIT: could fix it by manually re-running |
@asterikx - That's an expected error message and remediation steps for users of the new bootstrap style when upgrading as we've bumped bootstrap version (for new bootstrap users) with some updates to the template. The issue that required patching was the inability to upgrade the bootstrap stack successfully. |
but when I deploy my stack I am getting below validation error message: 'Parameters [/cdk-bootstrap/hnb659fds/version] referenced by template have types not supported by CloudFormation.', I am doubtful about below section in my cdk synth command output this section was not there before when I was using aws cdk version 1.53.0 Parameters: |
Hi @dhirajkhodade @shivlaks @rix0rrr I am using
|
Hi @suyashdb yes I have resolved this issue.
|
Bootstrapped using new style CDK bootstrap (BootstrapVersion: 3), then upgraded to CDK 1.61. Got errors like:
Did as instructed in the error and #8678 , but got the following:
Am I missing something obvious here?
This is 🐛 Bug Report
The text was updated successfully, but these errors were encountered: