Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): unable to upgrade new style bootstrap to version #10030

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

shivlaks
Copy link
Contributor

We were reading the wrong key when reading version source for template
resources. This prevented upgrade of bootstrap as the new version was
being incorrectly returned as 0.

Fixes #10016


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

We were reading the wrong key when reading version source for template
resources. This prevented upgrade of bootstrap as the new version was
being returned as `0` instead of `4`.

Fixes #10016
@shivlaks shivlaks added package/tools Related to AWS CDK Tools or CLI pr-linter/exempt-test The PR linter will not require test changes labels Aug 28, 2020
@shivlaks shivlaks requested a review from rix0rrr August 28, 2020 06:27
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 28, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 9dde324
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shivlaks shivlaks changed the title fix(cli): unable to upgrade new style bootstrap to version 4 fix(cli): unable to upgrade new style bootstrap to version Aug 28, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c5bb55c into master Aug 28, 2020
@mergify mergify bot deleted the shivlaks/bootstrapfailure branch August 28, 2020 07:30
RomainMuller pushed a commit that referenced this pull request Aug 28, 2020
We were reading the wrong key when reading version source for template
resources. This prevented upgrade of bootstrap as the new version was
being incorrectly returned as `0`.

Fixes #10016

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. package/tools Related to AWS CDK Tools or CLI pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cli] bootstrap upgrade to version 4 fails after upgrade from 1.60.0 to 1.61.0
3 participants