Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stepfunctions-tasks] complete codebuild parameters support #10302

Open
1 of 2 tasks
zxkane opened this issue Sep 11, 2020 · 8 comments · Fixed by #10356
Open
1 of 2 tasks

[stepfunctions-tasks] complete codebuild parameters support #10302

zxkane opened this issue Sep 11, 2020 · 8 comments · Fixed by #10356
Labels
@aws-cdk/aws-stepfunctions-tasks effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2

Comments

@zxkane
Copy link
Contributor

zxkane commented Sep 11, 2020

Step functions already supports codebuild task. But current L2 only supports EnvironmentVariablesOverride. There are still many parameters for codebuild task, for example, the source version.

https://docs.aws.amazon.com/step-functions/latest/dg/connect-codebuild.html

Use Case

Proposed Solution

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@zxkane zxkane added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 11, 2020
@SomayaB SomayaB changed the title [step-functions-tasks] complete codebuild parameters support [stepfunctions-tasks] complete codebuild parameters support Sep 11, 2020
@zxkane zxkane mentioned this issue Sep 15, 2020
Merged
@shivlaks shivlaks added p1 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Sep 15, 2020
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Sep 15, 2020
@zxkane zxkane mentioned this issue Sep 26, 2020
Merged
4 tasks
@mergify mergify bot closed this as completed in #10356 Nov 12, 2020
mergify bot pushed a commit that referenced this issue Nov 12, 2020
@zxkane
feat(stepfunctions-tasks): support overriding all properties of CodeB…
58efbad 
…uild StartBuild integration (#10356)


closes #10302 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@zxkane
Copy link
Contributor Author

zxkane commented Dec 17, 2020

@shivlaks Due to there is no progress on the underlying JSii issue, how about reopening this issue for tracking?

@zxkane
Copy link
Contributor Author

zxkane commented Apr 20, 2021

@SomayaB could you reopen this issue for tracking it in backlog? the PR was reverted due to jsii limitation.

@jesterhazy
Copy link
Contributor

are there any updates on this issue? it's still not fixed due to PR being reverted.

@BenChaimberg
Copy link
Contributor

#10356 was reverted in #11448 and so this feature was not implemented

@BenChaimberg BenChaimberg reopened this May 27, 2021
@BenChaimberg BenChaimberg removed their assignment Jun 22, 2021
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jul 23, 2022
@jesterhazy
Copy link
Contributor

any update on this issue?

@github-actions github-actions bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jul 24, 2022
@jesterhazy
Copy link
Contributor

any update on this issue?

@pahud pahud removed the p1 label Jun 11, 2024
@pahud pahud added the p2 label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-stepfunctions-tasks effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
No milestone
6 participants
@pahud @jesterhazy @zxkane @BenChaimberg @SomayaB @shivlaks