Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "feat(stepfunctions-tasks): support overriding all properties of CodeBuild StartBuild integration (#10356)" #11448

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

shivlaks
Copy link
Contributor

This reverts commit 58efbad.

We have a latent issue which fails on generating the Java code with:

ProjectProps.java:[10,8] interface software.amazon.awscdk.services.codebuild.ProjectProps
inherits unrelated defaults for getTimeout() from types software.amazon.awscdk.services.codebuild.StartBuildOptions
and software.amazon.awscdk.services.codebuild.CommonProjectProps

Reverting for now so we can sort the issue out and then we can re-introduce it.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

… of CodeBuild StartBuild integration (#10356)"

This reverts commit 58efbad.
@gitpod-io
Copy link

gitpod-io bot commented Nov 12, 2020

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 12, 2020
@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: f5f28e7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 13, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 47e28d4 into master Nov 13, 2020
@mergify mergify bot deleted the shivlaks/revert-sfn-tasks-codebuild branch November 13, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants