Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create GitHub Codespaces configuration for contributing guides along with Gitpod #10447

Closed
ayush987goyal opened this issue Sep 20, 2020 · 4 comments · Fixed by #10470
Closed

Create GitHub Codespaces configuration for contributing guides along with Gitpod #10447

ayush987goyal opened this issue Sep 20, 2020 · 4 comments · Fixed by #10470
Assignees
@skinny85
Labels
feature-request A feature should be added or improved. in-progress This issue is being actively worked on. third-party This issue is related to third-party libraries or applications.

Comments

@ayush987goyal
Copy link
Contributor

Now that GitHub Codespaces is in beta and available to a lot of people, we can create a configuration for this repository based on this document. This can be added as a secondary option to existing configuration for Gitpod
@ayush987goyal ayush987goyal added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Sep 20, 2020
@skinny85 skinny85 self-assigned this Sep 21, 2020
@skinny85
Copy link
Contributor

Hey @ayush987goyal ,

thanks for opening the issue. I would love to work on this, unfortunately, my account is still on the waitlist for the beta for CodeSpaces, so I don't think it's feasible for now (I assume a lot of our customers are on the waitlist as well).

Thanks,
Adam

@ayush987goyal
Copy link
Contributor Author

Hi @skinny85 ,

I have actually already started working on it in this fork. I ran into some issue for which I created a discussion topic on Codespaces team. You can follow the conversation there. I would raise the PR once I have a fix on the same.

@skinny85
Copy link
Contributor

Cool, thanks @ayush987goyal !

@skinny85 skinny85 added in-progress This issue is being actively worked on. and removed needs-triage This issue or PR still needs to be triaged. labels Sep 21, 2020
@SomayaB SomayaB added feature-request A feature should be added or improved. third-party This issue is related to third-party libraries or applications. and removed guidance Question that needs advice or information. labels Sep 22, 2020
@ayush987goyal ayush987goyal mentioned this issue Sep 22, 2020
Merged
@ayush987goyal
Copy link
Contributor Author

@skinny85 Here the the PR #10470

@mergify mergify bot closed this as completed in #10470 Sep 22, 2020
mergify bot pushed a commit that referenced this issue Sep 22, 2020
@ayush987goyal
feat: add configuration for GitHub CodeSpaces (#10470)
bf3cc21 
Add `.devcontainer.json` referencing the existing `.gitpod.yml` for supporting GitHub codespaces

closes #10447 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
feature-request A feature should be added or improved. in-progress This issue is being actively worked on. third-party This issue is related to third-party libraries or applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add configuration for GitHub CodeSpaces
3 participants
@skinny85 @ayush987goyal @SomayaB