Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add configuration for GitHub CodeSpaces #10470

Merged
merged 2 commits into from
Sep 22, 2020
Merged

feat: add configuration for GitHub CodeSpaces #10470

merged 2 commits into from
Sep 22, 2020

Conversation

ayush987goyal
Copy link
Contributor

Add .devcontainer.json referencing the existing .gitpod.yml for supporting GitHub codespaces

closes #10447

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@ayush987goyal ayush987goyal mentioned this pull request Sep 22, 2020
Closed
@ayush987goyal ayush987goyal changed the title choir(cdk): add devcontainer configuration for codespaces chore(cdk): add devcontainer configuration for codespaces Sep 22, 2020
@skinny85 skinny85 changed the title chore(cdk): add devcontainer configuration for codespaces feat: add configuration for GitHub CodeSpaces Sep 22, 2020
skinny85
skinny85 approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ayush987goyal !

@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 950cd19
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ayush987goyal
Copy link
Contributor Author

@skinny85 seems like the PR linter is failing post updating the commit title. I do not want to add anything to the readme yet since codespaces is still in beta and not available to all. Could you please override and merge?

@skinny85 skinny85 added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Sep 22, 2020
@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit bf3cc21 into aws:master Sep 22, 2020
@skinny85
Copy link
Contributor

Done 🙂

@ayush987goyal
Copy link
Contributor Author

Thanks :)

@ayush987goyal ayush987goyal deleted the pr/dev-container branch September 22, 2020 15:38
@jsteinich jsteinich mentioned this pull request Sep 24, 2020
Closed
@mrgrain mrgrain mentioned this pull request Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

Assignees
No one assigned
Labels
pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create GitHub Codespaces configuration for contributing guides along with Gitpod
3 participants
@ayush987goyal @aws-cdk-automation @skinny85