[aws-codecommit] cloneUrls returned from Repository.fromRepositoryArn(...) do not respect region in ARN

[raykrueger]

An IRepository instance created using Repository.fromRepositoryArn does not respect the region in the Arn. This results in a cloneUrl for the current stack region, not the region intended in the arn.

Reproduction Steps

const repo = Repository.fromRepositoryArn(stack, 'Repo', 'arn:aws:codecommit:us-east-1:1234567890:TestRepo');
console.log(repo.repositoryCloneUrlHttp);

What did you expect to happen?

While running my stack against us-west-2, I expect the clone url to come back with the region specified in the arn; us-east-1.

What actually happened?

Calls to repositoryCloneUrlHttp return a clone url targeting us-west-2, my stack region, not us-east-1 as specified in the arn.

Environment

• CLI Version : 1.65
• Framework Version: 1.65
• Node.js Version: 12.14.1
• OS : Macos
• Language (Version): ts 3.9.7

Other

As seen here, makeCloneUrl uses ${stack.region}

aws-cdk/packages/@aws-cdk/aws-codecommit/lib/repository.ts

Line 313 in 1c2cba4

return `${protocol}://git-codecommit.${stack.region}.${stack.urlSuffix}/v1/repos/${repositoryName}`;

---

This is 🐛 Bug Report

[raykrueger]

Made a few edits to clarify the region mismatch where I said us-east-2 but meant us-east-1. Also corrected the "Other" url to point to the correct location, I was linking to an old version I was looking at for regressions.

[skinny85]

Thanks for reporting @raykrueger . This seems like a simple fix - I think you've already identified where the problem is. Any chance you could submit us a PR with a fix for this? Our docs talk about getting started with contributing to the CDK: https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md

Thanks,
Adam

[raykrueger]

Yep, happy to work on a fix. I'm building a workaround in my app that I need first :)

[raykrueger]

PR incoming shortly