fix(codecommit): use region given in fromRepositoryArn when creating clone urls #10639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
As a CDK User I expect Repository.fromRepositoryArn to use the region given when building the repository clone urls. Prior to this commit, a stack deploy in us-east-1, would return clone urls for us-east-1 even if given an ARN for us-west-2. Fixes aws#10630
raykrueger
force-pushed
the
raykrueger/fix-10630
branch
from
6c66041 to
875245d
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
skinny85
approved these changes
Oct 1, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a CDK User I expect Repository.fromRepositoryArn to use the region
given when building the repository clone urls.
Prior to this commit, a stack deploy in us-east-1, would return clone
urls for us-east-1 even if given an ARN for us-west-2.
Fixes #10630
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license