Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Support disabling version check #10974

Closed
1 of 2 tasks
christophgysin opened this issue Oct 20, 2020 · 1 comment · Fixed by #10975
Closed
1 of 2 tasks

[cli] Support disabling version check #10974

christophgysin opened this issue Oct 20, 2020 · 1 comment · Fixed by #10975
Assignees
@rix0rrr
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged. p2 package/tools Related to AWS CDK Tools or CLI

Comments

@christophgysin
Copy link
Contributor

#2484 introduced a check for newer versions of aws-cdk. Please provide a way to disable it.

Use Case

I have other means to check for new versions of aws-cdk, and don't want the CLI to make unnecessary network requests.

Proposed Solution

Provide an environment variable that can be defined to disable the check.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@christophgysin christophgysin added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 20, 2020
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Oct 20, 2020
christophgysin added a commit to christophgysin/aws-cdk that referenced this issue Oct 20, 2020
@christophgysin
feat(cli): Support disabling version check
4d829fd 
If AWS_CDK_DISABLE_VERSION_CHECK is defined, skip checking for newer
versions.

fixes aws#10974
@christophgysin christophgysin mentioned this issue Oct 20, 2020
Merged
christophgysin added a commit to christophgysin/aws-cdk that referenced this issue Oct 20, 2020
@christophgysin
feat(cli): Support disabling version check
73d1aa3 
If AWS_CDK_DISABLE_VERSION_CHECK is defined, skip checking for newer
versions.

fixes aws#10974
christophgysin added a commit to christophgysin/aws-cdk that referenced this issue Oct 20, 2020
@christophgysin
feat(cli): Support disabling version check
116428b 
If AWS_CDK_DISABLE_VERSION_CHECK is defined, skip checking for newer
versions.

fixes aws#10974
christophgysin added a commit to christophgysin/aws-cdk that referenced this issue Oct 20, 2020
@christophgysin
feat(cli): Support disabling version check
f682f48 
If AWS_CDK_DISABLE_VERSION_CHECK is defined, skip checking for newer
versions.

fixes aws#10974
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Oct 21, 2020
@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort p2 labels Oct 26, 2020
@mergify mergify bot closed this as completed in #10975 Oct 26, 2020
mergify bot pushed a commit that referenced this issue Oct 26, 2020
@christophgysin
feat(cli): disable version check (#10975)
575e47e 
If AWS_CDK_DISABLE_VERSION_CHECK is defined, skip checking for newer
versions.

fixes #10974


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged. p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): disable version check christophgysin/aws-cdk
3 participants
@rix0rrr @christophgysin @SomayaB