Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): disable version check #10975

Merged
merged 4 commits into from
Oct 26, 2020

Conversation

christophgysin
Copy link
Contributor

If AWS_CDK_DISABLE_VERSION_CHECK is defined, skip checking for newer
versions.

fixes #10974


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 20, 2020

@christophgysin christophgysin force-pushed the disable-version-check branch 2 times, most recently from 73d1aa3 to 116428b Compare October 20, 2020 09:17
If AWS_CDK_DISABLE_VERSION_CHECK is defined, skip checking for newer
versions.

fixes aws#10974
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the env var to CDK_DISABLE... to match the naming style of the other one?

@mergify mergify bot dismissed rix0rrr’s stale review October 26, 2020 10:36

Pull request has been modified.

@rix0rrr rix0rrr changed the title feat(cli): Support disabling version check feat(cli): disable version check Oct 26, 2020
@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: fb98df1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 575e47e into aws:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cli] Support disabling version check
3 participants