Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdk init (typescript/app): move stack to a file under lib/xxx-stack.ts #1128

Closed
eladb opened this issue Nov 8, 2018 · 0 comments · Fixed by #1209
Closed

cdk init (typescript/app): move stack to a file under lib/xxx-stack.ts #1128

eladb opened this issue Nov 8, 2018 · 0 comments · Fixed by #1209
Labels
ui Related to CLI User Interface issues

Comments

@eladb
Copy link
Contributor

eladb commented Nov 8, 2018

Currently the stack is in bin/ and that's non-idiomatic.
@eladb eladb added the ui Related to CLI User Interface issues label Nov 13, 2018
rix0rrr added a commit that referenced this issue Nov 19, 2018
@rix0rrr
chore: move stack from 'bin' to a file in 'lib'
57700a7 
Generally we recommend people write reusable constructs in 'lib'
directories, and they should put stacks there as well.

Change the init template to reflect this change.

Fixes #1128.
@rix0rrr rix0rrr mentioned this issue Nov 19, 2018
Merged
2 tasks
rix0rrr added a commit that referenced this issue Nov 20, 2018
@rix0rrr
fix(cdk init): update 'app' init template (#1209)
402cbc4 
To avoid people having to clear out their template from the generated
topic and queue after they run 'cdk init app', make the 'app' template an
empty CDK project.

The original code has been moved to 'cdk init sample-app' (aliases: 'cdk
init sample', 'cdk init example').

Fixes #1124.

Also change the content of the templates. We recommend people write reusable constructs in 'lib'
directories, and they should put stacks there as well.

Change both init templates to reflect this change.

Fixes #1128.

The 'lib' init template used 'QueueArn' but that no long exists.

Fixes #1214.
rix0rrr added a commit that referenced this issue Nov 21, 2018
@rix0rrr
fix(cdk init): update 'app' init template (#1209)
0287109 
To avoid people having to clear out their template from the generated
topic and queue after they run 'cdk init app', make the 'app' template an
empty CDK project.

The original code has been moved to 'cdk init sample-app' (aliases: 'cdk
init sample', 'cdk init example').

Fixes #1124.

Also change the content of the templates. We recommend people write reusable constructs in 'lib'
directories, and they should put stacks there as well.

Change both init templates to reflect this change.

Fixes #1128.

The 'lib' init template used 'QueueArn' but that no long exists.

Fixes #1214.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui Related to CLI User Interface issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cdk init): update 'app' init template aws/aws-cdk
1 participant
@eladb