fix(cdk init): update 'app' init template #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generally we recommend people write reusable constructs in 'lib' directories, and they should put stacks there as well. Change the init template to reflect this change. Fixes #1128.
rix0rrr
changed the title
rix0rrr
changed the title
To avoid people having to clear out their template from the generated topic and queue after they run 'cdk init app', make the 'app' template an empty CDK project. The original code has been moved to 'cdk init sample-app' (aliases: 'cdk init sample', 'cdk init example'). Fixes #1124. TO DO AFTER MERGING: - [ ] Update workshop text to use new template
rix0rrr
changed the title
eladb
approved these changes
Nov 19, 2018
packages/aws-cdk/lib/init-templates/app/typescript/package.template.json
Show resolved
Hide resolved
The init template used 'QueueArn' but that no long exists. Add integ test. Fixes #1214.
rix0rrr
added a commit
that referenced
this pull request
Nov 21, 2018
This reverts commit 402cbc4 for the upcoming release.
rix0rrr
added a commit
that referenced
this pull request
Nov 21, 2018
To avoid people having to clear out their template from the generated topic and queue after they run 'cdk init app', make the 'app' template an empty CDK project. The original code has been moved to 'cdk init sample-app' (aliases: 'cdk init sample', 'cdk init example'). Fixes #1124. Also change the content of the templates. We recommend people write reusable constructs in 'lib' directories, and they should put stacks there as well. Change both init templates to reflect this change. Fixes #1128. The 'lib' init template used 'QueueArn' but that no long exists. Fixes #1214.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid people having to clear out their template from the generated
topic and queue after they run 'cdk init app', make the 'app' template an
empty CDK project.
The original code has been moved to 'cdk init sample-app' (aliases: 'cdk
init sample', 'cdk init example').
Fixes #1124.
Also change the content of the templates. We recommend people write reusable constructs in 'lib'
directories, and they should put stacks there as well.
Change both init templates to reflect this change.
Fixes #1128.
TO DO AFTER MERGING:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.