(eks): config aws-node-termination-handler image use public ECR

[neilkuan]

If you want to use spot worker node, aws-eks construct will help you install aws-node-termination-handler.
Now helm chart will pull image from docker hub by default.

see this repo:
https://github.com/aws/aws-node-termination-handler/blob/7ec2ce5457fd7a8a3d4fe0fb3f95445cb1cde9fc/config/helm/aws-node-termination-handler/values.yaml#L5-L9

Since dockerhub has begun rate limiting pulls, it will affect many CDK users with aws-eks construct.

aws-cdk/packages/@aws-cdk/aws-eks/lib/cluster.ts

Lines 1464 to 1474 in d5afb55

	if (!this._spotInterruptHandler) {
	this._spotInterruptHandler = this.addHelmChart('spot-interrupt-handler', {
	chart: 'aws-node-termination-handler',
	version: '0.9.5',
	repository: 'https://aws.github.io/eks-charts',
	namespace: 'kube-system',
	values: {
	'nodeSelector.lifecycle': LifecycleLabel.SPOT,
	},
	});
	}

Proposed Solution

see this PR: aws/aws-node-termination-handler#325

aws-node-termination-handler can pull from https://gallery.ecr.aws/r6b0f9a1/aws-node-termination-handler now.
I will create the PR for this

 if (!this._spotInterruptHandler) { 
   this._spotInterruptHandler = this.addHelmChart('spot-interrupt-handler', { 
     chart: 'aws-node-termination-handler', 
     version: '0.9.5', 
     repository: 'https://aws.github.io/eks-charts', 
     namespace: 'kube-system', 
     values: { 
       'nodeSelector.lifecycle': LifecycleLabel.SPOT,
       'image': {
            repository: 'public.ecr.aws/r6b0f9a1/aws-node-termination-handler',
          },
     }, 
   }); 
 } 

Other

• 👋 I may be able to implement this feature request
• ⚠️ This feature might incur a breaking change

---

This is a 🚀 Feature Request

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.