Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eks): aws-node-termination-handler for spot instances now pulls the image from public ECR #12141

Merged
merged 11 commits into from
Dec 25, 2020
Merged

feat(eks): aws-node-termination-handler for spot instances now pulls the image from public ECR #12141

merged 11 commits into from
Dec 25, 2020

Conversation

neilkuan
Copy link
Contributor

@neilkuan neilkuan commented Dec 17, 2020 •
edited
Loading

close #12134

update aws-node-termination-handler version to 0.13.2

this._spotInterruptHandler = this.addHelmChart('spot-interrupt-handler', {
        chart: 'aws-node-termination-handler',
        version: '0.13.2',
        repository: 'https://aws.github.io/eks-charts',
        namespace: 'kube-system',
        values: {
          'nodeSelector.lifecycle': LifecycleLabel.SPOT,
        },
      });

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 17, 2020 •
edited
Loading

@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Dec 17, 2020
@neilkuan neilkuan changed the title feat(eks): support aws-node-termination-handler image from public ECR fix(eks): support aws-node-termination-handler image from public ECR Dec 17, 2020
@neilkuan
Copy link
Contributor Author

aws-node-termination-handler just release version 0.13.2, config repository: public.ecr.aws/r6b0f9a1/aws-node-termination-handler by default .
https://github.com/aws/aws-node-termination-handler/blob/fe691872e75b737e19d0edd85db359091c996d63/config/helm/aws-node-termination-handler/values.yaml#L6
https://github.com/aws/aws-node-termination-handler/blob/v1.11.2/config/helm/aws-node-termination-handler/Chart.yaml

@neilkuan
Copy link
Contributor Author

waiting for https://github.com/aws/aws-node-termination-handler/actions/runs/429305845
release success...

@neilkuan neilkuan mentioned this pull request Dec 19, 2020
Closed
@neilkuan
Copy link
Contributor Author

Hi @iliapolo , please review ;)
截圖 2020-12-24 上午9 55 51

@iliapolo
Copy link
Contributor

@guan840912 So version 0.13.2 pulls from ECR by default?

Also notice there is a conflict.

@bwagner5
Copy link
Contributor

Yes, aws-node-termination-handler helm chart v0.13.2, now, by default, pulls v1.11.2+ from the ECR public gallery.

aws/eks-charts@139cfc3

@neilkuan
Copy link
Contributor Author

Hi @iliapolo, fixed the conflict :)

@iliapolo iliapolo changed the title fix(eks): support aws-node-termination-handler image from public ECR feat(eks): aws-node-termination-handler now pulls the image from public ECR Dec 25, 2020
@iliapolo iliapolo changed the title feat(eks): aws-node-termination-handler now pulls the image from public ECR feat(eks): aws-node-termination-handler for spot instances now pulls the image from public ECR Dec 25, 2020
iliapolo
iliapolo previously approved these changes Dec 25, 2020
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Dec 25, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@iliapolo iliapolo added the pr-linter/exempt-readme The PR linter will not require README changes label Dec 25, 2020
@mergify mergify bot dismissed iliapolo’s stale review December 25, 2020 12:08

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Dec 25, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c752fab into aws:master Dec 25, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 89cd097
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
@neilkuan @flochaz
feat(eks): aws-node-termination-handler for spot instances now pulls …
65c3618 
…the image from public ECR (aws#12141)

close aws#12134 

update `aws-node-termination-handler` version to `0.13.2`
```ts
this._spotInterruptHandler = this.addHelmChart('spot-interrupt-handler', {
        chart: 'aws-node-termination-handler',
        version: '0.13.2',
        repository: 'https://aws.github.io/eks-charts',
        namespace: 'kube-system',
        values: {
          'nodeSelector.lifecycle': LifecycleLabel.SPOT,
        },
      });
```

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@neilkuan neilkuan deleted the aws-node-termination-handler-image branch November 22, 2021 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliapolo iliapolo iliapolo approved these changes

Assignees

@iliapolo iliapolo

Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(eks): config aws-node-termination-handler image use public ECR
4 participants
@neilkuan @iliapolo @bwagner5 @aws-cdk-automation