(aws-cognito): Lambda Trigger lambda.Code.fromInline() example should be valid

[douglasnaphas]

https://docs.aws.amazon.com/cdk/api/latest/docs/aws-cognito-readme.html#lambda-triggers

The code sample at the above link has

const authChallengeFn = new lambda.Function(this, 'authChallengeFn', {
  runtime: lambda.Runtime.NODEJS_10_X,
  handler: 'index.handler',
  code: lambda.Code.fromInline('auth challenge'),
});

and

userpool.addTrigger(cognito.UserPoolOperation.USER_MIGRATION, new lambda.Function(this, 'userMigrationFn', {
    runtime: lambda.Runtime.NODEJS_10_X,
  handler: 'index.handler',
  code: lambda.Code.fromInline('user migration'),
}));

The argument to lambda.Code.fromInline is supposed to be valid function code, like in the example at Lambda with DLQ:

...
code: lambda.Code.fromInline('exports.handler = function(event, ctx, cb) { return cb(null, "hi"); }'),
...

It is confusing for readers to have something syntactically invalid like lambda.Code.fromInline('auth challenge') in the docs. We should replace 'auth challenge' and 'user migration' with syntactically valid function code, or use lambda.Code.fromAsset instead of fromInline.

---

This is a 📕 documentation issue

[nija-at]

You make a good point @douglasnaphas.

We should just use fromAsset() or replace the property with ellipses instead of being specific to use Code.fromInline(), like -

code: ...

Feel free to submit a PR for this.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.