-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws-cognito): Don't use {username} in verification email templates #12931
Labels
@aws-cdk/aws-cognito
Related to Amazon Cognito
documentation
This is a problem with documentation.
effort/small
Small work item – less than a day of effort
needs-triage
This issue or PR still needs to be triaged.
p2
Comments
douglasnaphas
added
documentation
This is a problem with documentation.
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
labels
Feb 9, 2021
Sounds good. I'm sure that 'Note' in the documentation is a recent additional and wasn't present when this code was original written. |
nija-at
added
effort/small
Small work item – less than a day of effort
p2
and removed
feature-request
A feature should be added or improved.
labels
Mar 22, 2021
|
nija-at
pushed a commit
that referenced
this issue
Mar 23, 2021
eladb
pushed a commit
that referenced
this issue
Mar 24, 2021
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this issue
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-cognito
Related to Amazon Cognito
documentation
This is a problem with documentation.
effort/small
Small work item – less than a day of effort
needs-triage
This issue or PR still needs to be triaged.
p2
https://docs.aws.amazon.com/cdk/api/latest/docs/aws-cognito-readme.html#sign-up
The above link has this code sample for setting up user verification:
But the Message Template docs say:
Remove
{username}
fromemailBody
, if it is indeed invalid there. I have not tested whether theemailBody
andsmsMessage
from the docs will work in a real User Pool, but I intend to in a test project.This is a 📕 documentation issue
The text was updated successfully, but these errors were encountered: