Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bucket name check #1308

Closed
mouyigang opened this issue Dec 8, 2018 · 2 comments · Fixed by #2256 · May be fixed by MechanicalRock/account-reaper#6
Closed

Add bucket name check #1308

mouyigang opened this issue Dec 8, 2018 · 2 comments · Fixed by #2256 · May be fixed by MechanicalRock/account-reaper#6
Labels
@aws-cdk/aws-s3 Related to Amazon S3 feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md

Comments

@mouyigang
Copy link

Wonder if can do this at cdk diff stage

1/5 | 11:43:29 | UPDATE_FAILED | AWS::S3::Bucket | seleniumbase_bucket (seleniumbasebucket4FC88E60) Bucket name should not contain '_'
@rix0rrr rix0rrr added feature-request A feature should be added or improved. @aws-cdk/aws-s3 Related to Amazon S3 labels Dec 8, 2018
@eladb
Copy link
Contributor

eladb commented Dec 9, 2018

Absolutely. Should be easy to add this validation.

@eladb eladb added the good first issue Related to contributions. See CONTRIBUTING.md label Dec 9, 2018
@rix0rrr
Copy link
Contributor

rix0rrr commented Dec 9, 2018

We had some at some point but removed it because of stringified tokens. But that's just an if away

@nija-at nija-at mentioned this issue Apr 12, 2019
Merged
4 tasks
rix0rrr pushed a commit that referenced this issue Apr 16, 2019
@nija-at @rix0rrr
fix(s3): Add validations for S3 bucket names (#2256)
f810265 
Bucket names are verified to conform with rules published by S3 -
https://docs.aws.amazon.com/AmazonS3/latest/dev/BucketRestrictions.html

Fixes #1308
This was referenced Dec 12, 2019
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-s3 Related to Amazon S3 feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md
Projects
None yet
Milestone
No milestone
3 participants
@rix0rrr @eladb @mouyigang