fix(s3): Add validations for S3 bucket names #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bucket names are verified to conform with rules published by S3 - https://docs.aws.amazon.com/AmazonS3/latest/dev/BucketRestrictions.html fixes #1308
rix0rrr
reviewed
Apr 12, 2019
| if (/\.-|-\.|\.\./.test(bucketName)) { | ||
| errors.push('Bucket name must not have dash next to period, or period next to dash, or consecutive periods'); | ||
| } | ||
| if (/\d+\.\d+\.\d+\.\d+/.test(bucketName)) { |
There was a problem hiding this comment.
Is this how S3 validates? I feel like this might be prohibiting certain options that S3 would permit...
There was a problem hiding this comment.
Not sure if this is how S3 does it. I've reversed engineered their validations based on their rules here and manually trying out combinations.
Some of these are pretty straight forward, like length and character set, but the ones around IP and symbol combinations get more tricky.
I've picked combinations and regex that I should be more liberal than S3 (in that, S3 might have additional/stricter checks I don't have here), but would be ok with dropping the more tricky ones if you think they could potentially break customers.
What do you think?
nija-at
commented
Apr 12, 2019
added 4 commits
April 12, 2019 16:32
Misused the wrong assertion method previously. `ok` assertions don't fail when the conditional throws an exception.
Each class of failed bucket name validation shows the offset of the offending character.
As suggested on the PR review, current set of tests only validate that the offsets are computed correctly. This test verifies that the message is generated as expected.
eladb
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bucket names are verified to conform with rules published by S3 -
https://docs.aws.amazon.com/AmazonS3/latest/dev/BucketRestrictions.html
fixes #1308
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.