Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3): Add validations for S3 bucket names #2256

Merged
merged 6 commits into from
Apr 16, 2019
Merged

fix(s3): Add validations for S3 bucket names #2256

merged 6 commits into from
Apr 16, 2019

Commits on Apr 12, 2019

  1. fix(s3): Add validations for S3 bucket names

    Bucket names are verified to conform with rules published by S3 -
    https://docs.aws.amazon.com/AmazonS3/latest/dev/BucketRestrictions.html
    
    fixes #1308
    Niranjan Jayakar committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    3ac4f53 View commit details
    Browse the repository at this point in the history
  2. Replaced ok assertions with doesNotThrow.

    Misused the wrong assertion method previously. `ok` assertions don't
    fail when the conditional throws an exception.
    Niranjan Jayakar committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    8e74077 View commit details
    Browse the repository at this point in the history
  3. Skip bucket name validation checks for CDK tokens

    Niranjan Jayakar committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    de5c283 View commit details
    Browse the repository at this point in the history
  4. Fixed regexp for IP address to match entire string

    Niranjan Jayakar committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    e19b859 View commit details
    Browse the repository at this point in the history
  5. Error messages now include offending offset

    Each class of failed bucket name validation shows the offset of the
    offending character.
    Niranjan Jayakar committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    c9cdd27 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2019

  1. Additional test that validates the entire error message.

    As suggested on the PR review, current set of tests only validate that
    the offsets are computed correctly. This test verifies that the message
    is generated as expected.
    Niranjan Jayakar committed Apr 14, 2019
    Configuration menu
    Copy the full SHA
    a040f09 View commit details
    Browse the repository at this point in the history