Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(appmesh): virtual node validation doesn't catch adding more than one listener to a node #13549

Closed
misterjoshua opened this issue Mar 11, 2021 · 1 comment · Fixed by #13550
Closed
Assignees
Labels
@aws-cdk/aws-appmesh Related to AWS App Mesh bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@misterjoshua
Copy link
Contributor

misterjoshua commented Mar 11, 2021

The VirtualNode construct allows you to add more than one listener, but CloudFormation doesn't support more than one listener at a time. (CFN Docs)

Reproduction Steps

Add more than one listener to a Virtual Node and try to deploy.

new appmesh.VirtualNode(stack, 'VirtualNode', {
  mesh: appmesh.Mesh.fromMeshName(stack, 'Mesh', meshName),
  listeners: [
    appmesh.VirtualNodeListener.http(),
    appmesh.VirtualNodeListener.grpc(),
  ],
});

What did you expect to happen?

VirtualNode should throw an error when it detects my attempt to add a second listener.

What actually happened?

It successfully synthesized but failed to deploy a stack.

Environment

  • CDK CLI Version : 1.93.0
  • Framework Version: 1.93.0
  • Node.js Version: v14.15.1
  • OS : Linux
  • Language (Version): all

This is 🐛 Bug Report

@misterjoshua misterjoshua added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 11, 2021
@github-actions github-actions bot added the @aws-cdk/aws-appmesh Related to AWS App Mesh label Mar 11, 2021
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

mergify bot pushed a commit that referenced this issue Mar 18, 2021
…this time (#13550)

This PR adds a note that at most one listener may be added to a Virtual Node until App Mesh team adds support for multiple listeners per aws/aws-app-mesh-roadmap#120

Closes #13549

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb pushed a commit that referenced this issue Mar 24, 2021
…this time (#13550)

This PR adds a note that at most one listener may be added to a Virtual Node until App Mesh team adds support for multiple listeners per aws/aws-app-mesh-roadmap#120

Closes #13549

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
…this time (aws#13550)

This PR adds a note that at most one listener may be added to a Virtual Node until App Mesh team adds support for multiple listeners per aws/aws-app-mesh-roadmap#120

Closes aws#13549

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-appmesh Related to AWS App Mesh bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants