-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(appmesh): note that virtual nodes allow at most one listener at this time #13550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @misterjoshua!
Unfortunately, I don't think we can accept it in the current shape. The reason is that the AppMesh team is planning to lift this restriction in the future (see here), and thus we don't want to force AppMesh customers to update their CDK version to use the new capability. Otherwise, we could have modeled listeners: Listener[]
as listener: Listener
, and make it safe at compile-time!
What do you think about changing the documentation instead, to surface this limitation, and the fact that it might be lifted in the future?
Thanks,
Adam
@skinny85 No problem. I've reverted the behaviour changes and added a note to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @misterjoshua!
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…this time (#13550) This PR adds a note that at most one listener may be added to a Virtual Node until App Mesh team adds support for multiple listeners per aws/aws-app-mesh-roadmap#120 Closes #13549 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…this time (aws#13550) This PR adds a note that at most one listener may be added to a Virtual Node until App Mesh team adds support for multiple listeners per aws/aws-app-mesh-roadmap#120 Closes aws#13549 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR adds a note that at most one listener may be added to a Virtual Node until App Mesh team adds support for multiple listeners per aws/aws-app-mesh-roadmap#120
Closes #13549
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license