(ec2): typo variable name "clientVpnEndoint" #13810

do-su-0805 · 2021-03-26T02:49:35Z

❓ General Issue

The Question

i found wrong ~~variable~~ member name "clientVpnEndoint" in this PR feat(ec2): client vpn endpoint by jogold · Pull Request #12234 · aws/aws-cdk. Correctly "clientVpnEndpoint"

Environment

Module Version: v1.95.0

Other information

P.S. Probably here too https://github.com/aws/aws-cdk/pull/12234/files#diff-53d5a35c408bb5bcd8c3b8e135dbd00660447763e9003af414536ab603d4a25dR712. Correctly "addAuthorizationRule()"

rix0rrr · 2021-03-30T12:37:08Z

Great finds! If this is about released code, the proper solution would be to add a new member with the right name and add the @deprecated tag to the typo'ed members.

Mind submitting a PR for that?

do-su-0805 · 2021-03-30T12:46:53Z

Thank you for your reaction and for telling me how to fix it.It was good.
I'm sorry I just found it and haven't prepared a fix yet. Please submit the correction PR.

( I'll try good first issuenext time. thx! )

do-su-0805 · 2021-04-01T14:37:20Z

Sorry, It seems that you misunderstood your intention.
Unfortunately, I have no time to deal with this issue temporarily. I'd like to ask you leave it opened or close this for now. I'll create a PR in the next month or so.

BLasan · 2021-04-05T04:51:13Z

@rix0rrr @do-su-0805 If you guys don't mind shall I send a PR for this?

do-su-0805 · 2021-04-05T16:47:08Z

@BLasan Please by all means. I'm sorry I couldn't implement it.

cokia · 2021-05-22T10:08:32Z

I made a PR because this is not being solved.
I need a lot of feedback because this is my first contribution to this project
Thanks

aws#13810 Require either clientVpnEndoint (which has a typo and is deprecated in the related PR for this issue) or clientVpnEndpoint, but not both.

aws#13810

aws#13810 This is to fix a linter error. The linter prefers expect and toThrow over try-catch when statements in tests are expected to throw.

aws#13810 I am only testing the logic in the constructor that makes sure only one of ClientVpnEndoint (deprecated, typo) and ClientVpnEndpoint are supplied. This commit removes setup and tests that I had copied over from another test, code that does not relate to the behavior under test.

aws#13810

aws#13810 This modifies the annotations for clientVpnEndoint to match with elsewhere in aws#14902. The reasoning for the deprecation ("by typo") can be left to the commit and PR history.

aws#13810 We want existing usages of the deprecated prop clientVpnEndoint [sic] to still work.

aws#13810

aws#13810 We are deprecating the prop ClientVpnEndoint [sic] due to a typo. This commit sets up the ClientVpnRoute constructor to require one or the other of clientVpnEndoint (the deprecated name) or clientVpnEndpoint.

aws#13810 Require either clientVpnEndoint (which has a typo and is deprecated in the related PR for this issue) or clientVpnEndpoint, but not both.

aws#13810

aws#13810 This is to fix a linter error. The linter prefers expect and toThrow over try-catch when statements in tests are expected to throw.

aws#13810 I am only testing the logic in the constructor that makes sure only one of ClientVpnEndoint (deprecated, typo) and ClientVpnEndpoint are supplied. This commit removes setup and tests that I had copied over from another test, code that does not relate to the behavior under test.

aws#13810

aws#13810 This modifies the annotations for clientVpnEndoint to match with elsewhere in aws#14902. The reasoning for the deprecation ("by typo") can be left to the commit and PR history.

aws#13810 We want existing usages of the deprecated prop clientVpnEndoint [sic] to still work.

aws#13810

aws#13810 We are deprecating the prop ClientVpnEndoint [sic] due to a typo. This commit sets up the ClientVpnRoute constructor to require one or the other of clientVpnEndoint (the deprecated name) or clientVpnEndpoint.

@rix0rrr

It is a solution to the issue #13810 Corrected the typo "clientVpnEndpoint" in the ec2 module to "clientVpnEnpoint". The maintainer (@rix0rrr) talked about @deprecated tags on existing incorrect members in the issue thread, but I didn't work on it because I thought it was an internal reference member. (if @deprecated tag is the rule of this repository in this case, please comment). This is my first commitment to this report. If there's anything wrong, please let me know in the comments. thanks ---- edit ----- Originally, this PR was #14835 , but I deleted my fork report by mistake, so I couldn't correct the error, so I uploaded it again.

@rix0rrr

It is a solution to the issue aws#13810 Corrected the typo "clientVpnEndpoint" in the ec2 module to "clientVpnEnpoint". The maintainer (@rix0rrr) talked about @deprecated tags on existing incorrect members in the issue thread, but I didn't work on it because I thought it was an internal reference member. (if @deprecated tag is the rule of this repository in this case, please comment). This is my first commitment to this report. If there's anything wrong, please let me know in the comments. thanks ---- edit ----- Originally, this PR was aws#14835 , but I deleted my fork report by mistake, so I couldn't correct the error, so I uploaded it again.

jumic · 2021-09-02T09:45:36Z

@peterwoodworth Could you please close this issue? It was resolved by PR #14902. Thanks.

github-actions · 2021-09-02T10:05:36Z

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@rix0rrr

It is a solution to the issue aws#13810 Corrected the typo "clientVpnEndpoint" in the ec2 module to "clientVpnEnpoint". The maintainer (@rix0rrr) talked about @deprecated tags on existing incorrect members in the issue thread, but I didn't work on it because I thought it was an internal reference member. (if @deprecated tag is the rule of this repository in this case, please comment). This is my first commitment to this report. If there's anything wrong, please let me know in the comments. thanks ---- edit ----- Originally, this PR was aws#14835 , but I deleted my fork report by mistake, so I couldn't correct the error, so I uploaded it again.

do-su-0805 added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Mar 26, 2021

github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Mar 26, 2021

github-actions bot assigned rix0rrr Mar 26, 2021

rix0rrr added bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2 and removed guidance Question that needs advice or information. labels Mar 30, 2021

cokia mentioned this issue May 22, 2021

fix(ec2): typo at member name "clientVpnEndoint" to "clientVpnEndpoint" #14835

Closed

cokia mentioned this issue May 27, 2021

fix(ec2): "clientVpnEndoint" => "clientVpnEndpoint" #14902

Merged

ryparker removed the needs-triage This issue or PR still needs to be triaged. label Jun 1, 2021

rix0rrr assigned njlynch and unassigned rix0rrr Jun 3, 2021

ericzbeard unassigned njlynch Jun 17, 2021

NetaNir mentioned this issue Jun 29, 2021

Is it typo? clientVpnEndoint, not clientVpnEndpoint? #15337

Closed

douglasnaphas added a commit to douglasnaphas/aws-cdk that referenced this issue Jul 11, 2021

Require either typo-ed or correct property

654cb4c

aws#13810 Require either clientVpnEndoint (which has a typo and is deprecated in the related PR for this issue) or clientVpnEndpoint, but not both.

douglasnaphas added a commit to douglasnaphas/aws-cdk that referenced this issue Jul 11, 2021

Don't change the stack when constructor's invalid

89d10f7

aws#13810

douglasnaphas added a commit to douglasnaphas/aws-cdk that referenced this issue Jul 11, 2021

Add details to ClientVpnAuthorizationRule errors

d0c5c24

aws#13810

douglasnaphas added a commit to douglasnaphas/aws-cdk that referenced this issue Jul 11, 2021

Use expect and toThrow instead of try-catch

18a59f4

aws#13810 This is to fix a linter error. The linter prefers expect and toThrow over try-catch when statements in tests are expected to throw.

douglasnaphas added a commit to douglasnaphas/aws-cdk that referenced this issue Jul 12, 2021

Remove extra line break

146647e

aws#13810

douglasnaphas added a commit to douglasnaphas/aws-cdk that referenced this issue Jul 13, 2021

Support continued use of deprecated prop

7636436

aws#13810 We want existing usages of the deprecated prop clientVpnEndoint [sic] to still work.

douglasnaphas added a commit to douglasnaphas/aws-cdk that referenced this issue Jul 18, 2021

Give descriptive names to Rules in tests

c42a92a

aws#13810

douglasnaphas added a commit to douglasnaphas/aws-cdk that referenced this issue Jul 18, 2021

Require either typo-ed or correct property

33c6e9b

aws#13810 Require either clientVpnEndoint (which has a typo and is deprecated in the related PR for this issue) or clientVpnEndpoint, but not both.

douglasnaphas added a commit to douglasnaphas/aws-cdk that referenced this issue Jul 18, 2021

Don't change the stack when constructor's invalid

88588d8

aws#13810

douglasnaphas added a commit to douglasnaphas/aws-cdk that referenced this issue Jul 18, 2021

Add details to ClientVpnAuthorizationRule errors

9091b1d

aws#13810

douglasnaphas added a commit to douglasnaphas/aws-cdk that referenced this issue Jul 18, 2021

Use expect and toThrow instead of try-catch

cbaffe7

aws#13810 This is to fix a linter error. The linter prefers expect and toThrow over try-catch when statements in tests are expected to throw.

douglasnaphas added a commit to douglasnaphas/aws-cdk that referenced this issue Jul 18, 2021

Remove extra line break

31dc1bf

aws#13810

douglasnaphas added a commit to douglasnaphas/aws-cdk that referenced this issue Jul 18, 2021

Support continued use of deprecated prop

1e6013e

aws#13810 We want existing usages of the deprecated prop clientVpnEndoint [sic] to still work.

douglasnaphas added a commit to douglasnaphas/aws-cdk that referenced this issue Jul 18, 2021

Give descriptive names to Rules in tests

9fee343

aws#13810

njlynch closed this as completed Sep 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(ec2): typo variable name "clientVpnEndoint" #13810

(ec2): typo variable name "clientVpnEndoint" #13810

do-su-0805 commented Mar 26, 2021 •

edited

Loading

rix0rrr commented Mar 30, 2021

do-su-0805 commented Mar 30, 2021 •

edited

Loading

do-su-0805 commented Apr 1, 2021

BLasan commented Apr 5, 2021

do-su-0805 commented Apr 5, 2021

cokia commented May 22, 2021

jumic commented Sep 2, 2021

github-actions bot commented Sep 2, 2021

(ec2): typo variable name "clientVpnEndoint" #13810

(ec2): typo variable name "clientVpnEndoint" #13810

Comments

do-su-0805 commented Mar 26, 2021 • edited Loading

❓ General Issue

The Question

Environment

Other information

rix0rrr commented Mar 30, 2021

do-su-0805 commented Mar 30, 2021 • edited Loading

do-su-0805 commented Apr 1, 2021

BLasan commented Apr 5, 2021

do-su-0805 commented Apr 5, 2021

cokia commented May 22, 2021

jumic commented Sep 2, 2021

github-actions bot commented Sep 2, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

do-su-0805 commented Mar 26, 2021 •

edited

Loading

do-su-0805 commented Mar 30, 2021 •

edited

Loading