Give descriptive names to Rules in tests

aws#13810
douglasnaphas · Jul 18, 2021 · 9fee343 · 9fee343
1 parent 1e6013e
commit 9fee343
Showing 1 changed file with 15 additions and 5 deletions.
diff --git a/packages/@aws-cdk/aws-ec2/test/client-vpn-authorization-rule.test.ts b/packages/@aws-cdk/aws-ec2/test/client-vpn-authorization-rule.test.ts
@@ -18,13 +18,18 @@ describe('ClientVpnAuthorizationRule constructor', () => {
       connections: new Connections(),
       node: stack.node,
     };
-    new ClientVpnAuthorizationRule(stack, 'Rule', { cidr: '10.0.10.0/32', clientVpnEndpoint });
+    new ClientVpnAuthorizationRule(stack, 'NormalRule', {
+      cidr: '10.0.10.0/32',
+      clientVpnEndpoint,
+    });
     expect(stack).toCountResources('AWS::EC2::ClientVpnAuthorizationRule', 1);
     expect(stack.node.children.length).toBe(1);
   });
   test('either clientVpnEndoint (deprecated, typo) or clientVpnEndpoint is required', () => {
     expect(() => {
-      new ClientVpnAuthorizationRule(stack, 'Rule', { cidr: '10.0.10.0/32' });
+      new ClientVpnAuthorizationRule(stack, 'RuleNoEndointNoEndpoint', {
+        cidr: '10.0.10.0/32',
+      });
     }).toThrow(
       new Error(
         'ClientVpnAuthorizationRule: either clientVpnEndpoint or clientVpnEndoint (deprecated) must be specified',
@@ -49,7 +54,7 @@ describe('ClientVpnAuthorizationRule constructor', () => {
       node: stack.node,
     };
     expect(() => {
-      new ClientVpnAuthorizationRule(stack, 'Rule', {
+      new ClientVpnAuthorizationRule(stack, 'RuleBothEndointAndEndpoint', {
         cidr: '10.0.10.0/32',
         clientVpnEndoint,
         clientVpnEndpoint,
@@ -63,7 +68,9 @@ describe('ClientVpnAuthorizationRule constructor', () => {
   });
   test('invalid constructor calls should not add anything to the stack', () => {
     expect(() => {
-      new ClientVpnAuthorizationRule(stack, 'InvalidRule', { cidr: '10.0.10.0/32' });
+      new ClientVpnAuthorizationRule(stack, 'RuleNoEndointNoEndpoint', {
+        cidr: '10.0.10.0/32',
+      });
     }).toThrow();
     expect(stack.node.children.length).toBe(0);
   });
@@ -76,7 +83,10 @@ describe('ClientVpnAuthorizationRule constructor', () => {
       connections: new Connections(),
       node: stack.node,
     };
-    new ClientVpnAuthorizationRule(stack, 'Rule', { cidr: '10.0.10.0/32', clientVpnEndoint });
+    new ClientVpnAuthorizationRule(stack, 'RuleWithEndointTypo', {
+      cidr: '10.0.10.0/32',
+      clientVpnEndoint,
+    });
     expect(stack).toCountResources('AWS::EC2::ClientVpnAuthorizationRule', 1);
     expect(stack.node.children.length).toBe(1);
   });