-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@aws-cdk/aws-appsync: Add ability to create resolvers with "operation": "BatchInvoke" #14079
Comments
Any chance of this getting implemented in the near future? |
@asnaseer-resilient the core team is not actively working on adding features to appsync right now. PRs from the community are always welcome or you may be able to implement this by extending the I don't have any experience using BatchInvoke in CFN, @BryanPan342 you have any guidance to add here for implementing? |
I also don't have experience with BatchInvoke, but it looks like a Mapping Template issue that I honestly don't have that good of an answer for 😔 I know @duarten created an RFC for mapping templates and I think that would be nice to have even though JS is looking like an alternative.. would definitely require more thought |
Most of that effort is in https://github.com/umani/ribosome, which works but isn't pretty (the API was designed to be compatible with the constraints of jsii, in case it would ever be merged into the cdk). But yeah, looking forward to JS resolvers :) |
I have had a look around the code base and I think the change would need to be made in mapping-template.ts in this method:
That method currently seems to hardwire the operation to "Invoke" as follows:
So maybe you could introduce an additional optional parameter as follows for backwards compatibility:
and then expose the ability to set this in the CDK. I am not really familiar enough with any of the CDK codebase to attempt to make any changes to it myself. |
@asnaseer-resilient I'm currently working on the schema validation PR, but ill see what I can do. It does seem pretty straightforward but I want to make sure I read more about mapping templates before I implement anything that will change the API. |
@BryanPan342 - Any updates on this? |
I'm finishing up my school quarter atm so don't have the bandwidth atm, but will look to implement it sometime in the summer |
… template (#15283) **[CORE CHANGES]** Add optional `operation` parameter to `lamdaRequest` mapping template. - Defaults to `"Invoke"` - Allows for `"BatchInvoke"` operations directly through the static `lambdaRequest` function **[MISC]** * Add integration test w/ a verification script to test mapping template * preliminary mapping template unit tests (created an issue to create more testing #15274 * Use `path.resolve()` to resolve testing integration test in different directories Fixes: #14079 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
… template (aws#15283) **[CORE CHANGES]** Add optional `operation` parameter to `lamdaRequest` mapping template. - Defaults to `"Invoke"` - Allows for `"BatchInvoke"` operations directly through the static `lambdaRequest` function **[MISC]** * Add integration test w/ a verification script to test mapping template * preliminary mapping template unit tests (created an issue to create more testing aws#15274 * Use `path.resolve()` to resolve testing integration test in different directories Fixes: aws#14079 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
… template (aws#15283) **[CORE CHANGES]** Add optional `operation` parameter to `lamdaRequest` mapping template. - Defaults to `"Invoke"` - Allows for `"BatchInvoke"` operations directly through the static `lambdaRequest` function **[MISC]** * Add integration test w/ a verification script to test mapping template * preliminary mapping template unit tests (created an issue to create more testing aws#15274 * Use `path.resolve()` to resolve testing integration test in different directories Fixes: aws#14079 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
I want to setup an AppSync resolver using the CDK to use
"operation": "BatchInvoke"
as described here https://docs.aws.amazon.com/appsync/latest/devguide/tutorial-lambda-resolvers.html#advanced-use-case-batchingI am currently using the createResolver function to create my resolvers but cannot see a way to specify this type of operation - see here: https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-appsync.LambdaDataSource.html#createwbrresolverpropsspan-[…]y-change-without-noticespan
Use Case
The link above describes my use case.
Proposed Solution
None
Other
N/A
This is a 🚀 Feature Request
The text was updated successfully, but these errors were encountered: