Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(appsync): optional operation parameter for lambdaRequest mapping template #15283

Merged
merged 5 commits into from
Jul 19, 2021
Merged

feat(appsync): optional operation parameter for lambdaRequest mapping template #15283

merged 5 commits into from
Jul 19, 2021

Conversation

BryanPan342
Copy link
Contributor

[CORE CHANGES]
Add optional operation parameter to lamdaRequest mapping template.

  • Defaults to "Invoke"
  • Allows for "BatchInvoke" operations directly through the static lambdaRequest function

[MISC]

Fixes: #14079

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 23, 2021

@BryanPan342 BryanPan342 added the feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. label Jun 23, 2021
@BryanPan342
Copy link
Contributor Author

@asnaseer-resilient would love to know your thoughts! I have a working integration test that I think is pretty comprehensive but wouldn't mind a second glance

@BryanPan342 BryanPan342 added the pr-linter/exempt-readme The PR linter will not require README changes label Jun 23, 2021
@BryanPan342 BryanPan342 self-assigned this Jun 23, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 23, 2021
@BryanPan342 BryanPan342 added the @aws-cdk/aws-appsync Related to AWS AppSync label Jun 24, 2021
@asnaseer-resilient
Copy link

@asnaseer-resilient would love to know your thoughts! I have a working integration test that I think is pretty comprehensive but wouldn't mind a second glance

@BryanPan342 Looks perfect - I can't wait for this to be published. Thanks again for doing this 👍

@otaviomacedo otaviomacedo self-requested a review July 19, 2021 14:53
@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit efd2e68 into master Jul 19, 2021
@mergify mergify bot deleted the batch-invoke branch July 19, 2021 23:00
@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: d22cb0d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Aug 3, 2021
@BryanPan342 @TikiTDO
feat(appsync): optional operation parameter for lambdaRequest mapping…
c2576dc 
… template (aws#15283)

**[CORE CHANGES]**
Add optional `operation` parameter to `lamdaRequest` mapping template.
- Defaults to `"Invoke"`
- Allows for `"BatchInvoke"` operations directly through the static `lambdaRequest` function

**[MISC]**
* Add integration test w/ a verification script to test mapping template
* preliminary mapping template unit tests (created an issue to create more testing aws#15274 
* Use `path.resolve()` to resolve testing integration test in different directories

Fixes: aws#14079 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@BryanPan342 @hollanddd
feat(appsync): optional operation parameter for lambdaRequest mapping…
ee504d1 
… template (aws#15283)

**[CORE CHANGES]**
Add optional `operation` parameter to `lamdaRequest` mapping template.
- Defaults to `"Invoke"`
- Allows for `"BatchInvoke"` operations directly through the static `lambdaRequest` function

**[MISC]**
* Add integration test w/ a verification script to test mapping template
* preliminary mapping template unit tests (created an issue to create more testing aws#15274 
* Use `path.resolve()` to resolve testing integration test in different directories

Fixes: aws#14079 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaviomacedo otaviomacedo otaviomacedo approved these changes

Assignees

@BryanPan342 BryanPan342

Labels
@aws-cdk/aws-appsync Related to AWS AppSync contribution/core This is a PR that came from AWS. feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@aws-cdk/aws-appsync: Add ability to create resolvers with "operation": "BatchInvoke"
4 participants
@BryanPan342 @asnaseer-resilient @aws-cdk-automation @otaviomacedo