Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-cognito): Support MFA custom message #14084

Closed
1 of 2 tasks
acomagu opened this issue Apr 9, 2021 · 1 comment · Fixed by #14241
Closed
1 of 2 tasks

(aws-cognito): Support MFA custom message #14084

acomagu opened this issue Apr 9, 2021 · 1 comment · Fixed by #14241
Assignees
@nija-at
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/small Small work item – less than a day of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@acomagu
Copy link
Contributor

acomagu commented Apr 9, 2021 •
edited
Loading

Currently cognito.UserPool high level construct seems to have no ability to specify custom MFA message(SmsAuthenticationMessage field in CloudFormation). I wish it was supported.

Use Case

Specifying custom MFA message.

Proposed Solution

new cognito.UserPool(this, 'userPool', {
  ...
  mfa: Mfa.OPTIONAL,
  mfaMessage: 'Your authentication code is {####}.',  // New option.
});
  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@acomagu acomagu added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 9, 2021
@github-actions github-actions bot added the @aws-cdk/aws-cognito Related to Amazon Cognito label Apr 9, 2021
@acomagu acomagu changed the title (aws-cognito): Support MFA custom message. (aws-cognito): Support MFA custom message Apr 9, 2021
@nija-at nija-at added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2 and removed needs-triage This issue or PR still needs to be triaged. labels Apr 13, 2021
@cjihrig cjihrig mentioned this issue Apr 18, 2021
Merged
@peterwoodworth peterwoodworth added the feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs label Apr 20, 2021
@mergify mergify bot closed this as completed in #14241 Jun 4, 2021
mergify bot pushed a commit that referenced this issue Jun 4, 2021
@cjihrig
feat(cognito): user pool - customize mfa message (#14241)
a12db62 
This commit adds a new, optional `mfaMessage` to Cognito UserPools.

Fixes: #14084

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jun 4, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@cjihrig @hollanddd
feat(cognito): user pool - customize mfa message (aws#14241)
c5410b2 
This commit adds a new, optional `mfaMessage` to Cognito UserPools.

Fixes: aws#14084

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nija-at nija-at

Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/small Small work item – less than a day of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cognito): user pool - customize mfa message cjihrig/aws-cdk
3 participants
@acomagu @nija-at @peterwoodworth