Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cognito): user pool - customize mfa message #14241

Merged
merged 4 commits into from
Jun 4, 2021

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 18, 2021

This commit adds a new, optional mfaMessage to Cognito UserPools.

Fixes: #14084


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Apr 18, 2021

@cjihrig
Copy link
Contributor Author

cjihrig commented May 4, 2021

Ping @nija-at based on the assignment of #14084.

nija-at
nija-at previously requested changes Jun 1, 2021
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR @cjihrig. Apologies for the delayed response.

Could you address some of my comments below.

packages/@aws-cdk/aws-cognito/lib/user-pool.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cognito/lib/user-pool.ts Outdated Show resolved Hide resolved
@gitpod-io
Copy link

gitpod-io bot commented Jun 2, 2021

@mergify mergify bot dismissed nija-at’s stale review June 2, 2021 01:01

Pull request has been modified.

This commit adds a new, optional `mfaMessage` to
Cognito UserPools.
@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 2, 2021

Thanks for the review @nija-at. I have updated the PR based on your feedback.

@cjihrig cjihrig requested a review from nija-at June 3, 2021 01:38
nija-at
nija-at previously approved these changes Jun 3, 2021
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @cjihrig. Looks good!

@nija-at nija-at added the pr-linter/exempt-readme The PR linter will not require README changes label Jun 4, 2021
@nija-at nija-at changed the title feat(cognito-userpool): Add mfaMessage option feat(cognito-userpool): customize mfa message Jun 4, 2021
@nija-at nija-at changed the title feat(cognito-userpool): customize mfa message feat(cognito): user pool - customize mfa message Jun 4, 2021
@mergify mergify bot dismissed nija-at’s stale review June 4, 2021 09:54

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jun 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a12db62 into aws:master Jun 4, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 12d4f49
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@cjihrig cjihrig deleted the smsauthmsg branch June 4, 2021 14:39
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
This commit adds a new, optional `mfaMessage` to Cognito UserPools.

Fixes: aws#14084

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-cognito): Support MFA custom message
3 participants