Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-ecs-patterns): Allow ApplicationLoadBalanced*Service to pass in ProtocolVersion for HTTP2/GRPC support #14091

Closed
1 of 2 tasks
yiluncui opened this issue Apr 9, 2021 · 2 comments
Closed
1 of 2 tasks

(aws-ecs-patterns): Allow ApplicationLoadBalanced*Service to pass in ProtocolVersion for HTTP2/GRPC support #14091

yiluncui opened this issue Apr 9, 2021 · 2 comments
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library feature-request A feature should be added or improved.

Comments

@yiluncui
Copy link
Contributor

yiluncui commented Apr 9, 2021

#13570 adds support for the ALB constructs to specify ProtocolVersion in target groups, but this parameter isn't passed into the ecs-patterns high level construct.

Use Case

I want to create ALBs that support GRPC/HTTP2 protocols in their target groups using the ecs_patterns.ApplicationLoadBalanced___Service() pattern

Proposed Solution

Propagate the ProtocolVersion parameter to AddApplicationTargetsProps and ApplicationLoadBalancedServiceBaseProps

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@yiluncui yiluncui added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 9, 2021
yiluncui added a commit to yiluncui/aws-cdk that referenced this issue Apr 9, 2021
@yiluncui
fix(aws-ecs-patterns, aws-elasticloadbalancingv2): Pass TargetGroup P…
eff234b 
…rotocolVersion as parameters to higher level constructs (aws#14091)

This change allows users to optionally provide ProtocolVersion when
adding targets to ALB listeners as well as specifying ProtocolVersion
into ApplicationLoadBalancedService patterns in ecs-patterns.
@yiluncui yiluncui mentioned this issue Apr 9, 2021
Merged
@peterwoodworth peterwoodworth added the @aws-cdk/aws-ecs-patterns Related to ecs-patterns library label Apr 12, 2021
mergify bot pushed a commit that referenced this issue Apr 21, 2021
@yiluncui
fix(aws-ecs-patterns, aws-elasticloadbalancingv2): Pass TargetGroup P… (
a655819 
#14092)

Pass TargetGroup ProtocolVersion as parameters to higher level constructs (#14091)

This change allows users to optionally provide ProtocolVersion when
adding targets to ALB listeners as well as specifying ProtocolVersion
into ApplicationLoadBalancedService patterns in ecs-patterns.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@SoManyHs SoManyHs removed the needs-triage This issue or PR still needs to be triaged. label Apr 22, 2021
@SoManyHs
Copy link
Contributor

Closed by #14092. Thanks @yiluncui ! ❤️

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

john-tipper pushed a commit to john-tipper/aws-cdk that referenced this issue May 10, 2021
@yiluncui @john-tipper
fix(aws-ecs-patterns, aws-elasticloadbalancingv2): Pass TargetGroup P… (
4978895 
aws#14092)

Pass TargetGroup ProtocolVersion as parameters to higher level constructs (aws#14091)

This change allows users to optionally provide ProtocolVersion when
adding targets to ALB listeners as well as specifying ProtocolVersion
into ApplicationLoadBalancedService patterns in ecs-patterns.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@yiluncui @hollanddd
fix(aws-ecs-patterns, aws-elasticloadbalancingv2): Pass TargetGroup P… (
3fd25a9 
aws#14092)

Pass TargetGroup ProtocolVersion as parameters to higher level constructs (aws#14091)

This change allows users to optionally provide ProtocolVersion when
adding targets to ALB listeners as well as specifying ProtocolVersion
into ApplicationLoadBalancedService patterns in ecs-patterns.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@uttarasridhar @MrArnoldPalmer @SoManyHs @peterwoodworth @yiluncui