fix(aws-ecs-patterns, aws-elasticloadbalancingv2): Pass TargetGroup P… #14092
Conversation
…rotocolVersion as parameters to higher level constructs (aws#14091) This change allows users to optionally provide ProtocolVersion when adding targets to ALB listeners as well as specifying ProtocolVersion into ApplicationLoadBalancedService patterns in ecs-patterns.
|
|
github-actions
bot
added
the
@aws-cdk/aws-elasticloadbalancingv2
There was a problem hiding this comment.
Thanks for this contribution! The ELB stuff looks good to me. Pinging @MrArnoldPalmer or @SoManyHs to sign off on the ECS patterns stuff.
| @@ -363,6 +363,7 @@ export class ApplicationListener extends BaseListener implements IApplicationLis | |||
| healthCheck: props.healthCheck, | |||
| port: props.port, | |||
| protocol: props.protocol, | |||
| protocolVersion: props.protocolVersion, | |||
There was a problem hiding this comment.
What do you think about adding protocolVersion to AddApplicationTargetsProps as well?
There was a problem hiding this comment.
Are you referring to lines 798-812 later in this file?
There was a problem hiding this comment.
Oh yeah, sorry, must have mis-read the diff as-is. This looks great then.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws#14092) Pass TargetGroup ProtocolVersion as parameters to higher level constructs (aws#14091) This change allows users to optionally provide ProtocolVersion when adding targets to ALB listeners as well as specifying ProtocolVersion into ApplicationLoadBalancedService patterns in ecs-patterns. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws#14092) Pass TargetGroup ProtocolVersion as parameters to higher level constructs (aws#14091) This change allows users to optionally provide ProtocolVersion when adding targets to ALB listeners as well as specifying ProtocolVersion into ApplicationLoadBalancedService patterns in ecs-patterns. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Pass TargetGroup ProtocolVersion as parameters to higher level constructs (#14091)
This change allows users to optionally provide ProtocolVersion when
adding targets to ALB listeners as well as specifying ProtocolVersion
into ApplicationLoadBalancedService patterns in ecs-patterns.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license