Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CodeStarConnectionsSourceAction): vestigial BitBucket-only reference #14142

Closed
jrobbins-LiveData opened this issue Apr 13, 2021 · 5 comments · Fixed by #14155
Closed

(CodeStarConnectionsSourceAction): vestigial BitBucket-only reference #14142

jrobbins-LiveData opened this issue Apr 13, 2021 · 5 comments · Fixed by #14155
Assignees
@skinny85
Labels
documentation This is a problem with documentation. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@jrobbins-LiveData
Copy link
Contributor

The new CodeStarConnectionsSourceAction construct still refers only to BitBucket in its description of theconnection_arn parameter.

CodeStarConnectionsSourceAction

The description says:

The ARN of the CodeStar Connection created in the AWS console that has permissions to access this BitBucket repository.

It should say:

The ARN of the CodeStar Connection created in the AWS console that has permissions to access this GitHub or BitBucket repository.

codestarconnectionsourceaction_doc

This is a 📕 documentation issue
@jrobbins-LiveData jrobbins-LiveData added documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 13, 2021
@skinny85
Copy link
Contributor

Nice catch @jrobbins-LiveData, thanks! Any chance you could submit a quick PR fixing this? 😃

@skinny85 skinny85 self-assigned this Apr 13, 2021
@skinny85 skinny85 added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2 and removed needs-triage This issue or PR still needs to be triaged. labels Apr 13, 2021
@jrobbins-LiveData
Copy link
Contributor Author

@skinny85, happy to do so. Full confession -- I'm somewhat inexperienced with Git, so it might not happen right away as I try to figure out what to do!

@skinny85 skinny85 mentioned this issue Apr 13, 2021
Merged
@skinny85
Copy link
Contributor

Judging from #14155, you're pretty quick in figuring things out 😃.

@jrobbins-LiveData
Copy link
Contributor Author

jrobbins-LiveData commented Apr 13, 2021 via email

@mergify mergify bot closed this as completed in #14155 Apr 15, 2021
mergify bot pushed a commit that referenced this issue Apr 15, 2021
@jrobbins-LiveData
docs(codepipeline-actions): update CodeStarConnectionsSourceActionPro…
7cd5653 
…ps docs to also mention GitHub (#14155)

Expanded `CodeStarConnectionsSourceActionProps` doc comment to include GitHub repositories in addition to BitBucket repositories.

Fixes #14142

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@jrobbins-LiveData @hollanddd
docs(codepipeline-actions): update CodeStarConnectionsSourceActionPro…
c5333dd 
…ps docs to also mention GitHub (aws#14155)

Expanded `CodeStarConnectionsSourceActionProps` doc comment to include GitHub repositories in addition to BitBucket repositories.

Fixes aws#14142

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
documentation This is a problem with documentation. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
2 participants
@skinny85 @jrobbins-LiveData