Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(codepipeline-actions): update CodeStarConnectionsSourceActionProps docs to also mention GitHub #14155

Merged
merged 4 commits into from
Apr 15, 2021
Merged

docs(codepipeline-actions): update CodeStarConnectionsSourceActionProps docs to also mention GitHub #14155

merged 4 commits into from
Apr 15, 2021

Conversation

jrobbins-LiveData
Copy link
Contributor

@jrobbins-LiveData jrobbins-LiveData commented Apr 13, 2021 •
edited by skinny85
Loading

Expanded CodeStarConnectionsSourceActionProps doc comment to include GitHub repositories in addition to BitBucket repositories.

Fixes #14142

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jrobbins-LiveData
Update source-action.ts
527bdbb 
Expanded `CodeStarConnectionsSourceActionProps` doc comment to include GitHub repositories in addition to BitBucket repositories.
@gitpod-io
Copy link

gitpod-io bot commented Apr 13, 2021 •
edited
Loading

@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

skinny85
skinny85 approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast @jrobbins-LiveData, thanks!

@skinny85 skinny85 changed the title Update source-action.ts CodeStarConnectionsSourceActionProps docstring docs(codepipeline-actions): update CodeStarConnectionsSourceActionProps docs to also mention GitHub Apr 13, 2021
@skinny85 skinny85 mentioned this pull request Apr 13, 2021
Closed
@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@rix0rrr
Copy link
Contributor

rix0rrr commented Apr 15, 2021

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2021

Command refresh: success

Pull request refreshed

@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: abd73e1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7cd5653 into aws:master Apr 15, 2021
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@jrobbins-LiveData @hollanddd
docs(codepipeline-actions): update CodeStarConnectionsSourceActionPro…
c5333dd 
…ps docs to also mention GitHub (aws#14155)

Expanded `CodeStarConnectionsSourceActionProps` doc comment to include GitHub repositories in addition to BitBucket repositories.

Fixes aws#14142

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-codepipeline-actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(CodeStarConnectionsSourceAction): vestigial BitBucket-only reference
4 participants
@jrobbins-LiveData @rix0rrr @aws-cdk-automation @skinny85