(aws-cdk/aws-amplify): basicAuth cannot be removed

[mwiarda-fette]

Hi,

basicAuth can be enabled on an amplify application using the cdk.
Unfortunately, that setting can not be reversed. The cloudformation template changes but basic auth is still active in amplify.

Reproduction Steps

1. Create new amplify app with basic auth:

import * as codebuild from '@aws-cdk/aws-codebuild';
import * as amplify from '@aws-cdk/aws-amplify';
import * as cdk from '@aws-cdk/core';

const amplifyApp = new amplify.App(this, 'MyApp', {
  basicAuth: amplify.BasicAuth.fromCredentials("admin", this.secret.secretValueFromJson("password")),
  sourceCodeProvider: new amplify.GitHubSourceCodeProvider({
    owner: '<user>',
    repository: '<repo>',
    oauthToken: cdk.SecretValue.secretsManager('my-github-token')
  }),
  buildSpec: codebuild.BuildSpec.fromObjectToYaml({ // Alternatively add a `amplify.yml` to the repo
    version: '1.0',
    frontend: {
      phases: {
        preBuild: {
          commands: [
            'yarn'
          ]
        },
        build: {
          commands: [
            'yarn build'
          ]
        }
      },
      artifacts: {
        baseDirectory: 'public',
        files: '**/*'
      }
    }
  })
});

2. Website should now be password protected
3. Remove line basicAuth: amplify.BasicAuth.fromCredentials("admin", this.secret.secretValueFromJson("password"))
4. App is still password protected

What did you expect to happen?

Password protection should be removed

What actually happened?

Template changes (shows in cdk diff) but protection not removed in amplify

---

This is 🐛 Bug Report

[skinny85]

Hi @mwiarda-fette,

thanks for opening the issue. Do you perhaps have Premium Support? I think this might be worth it to open to the Amplify team directly - looks like their CloudFormation support does not handle edits correctly. Unfortunately, there's not much we can do here from the CDK side.

Thanks,
Adam

[jogold]

There's maybe something to do with https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-amplify-app-basicauthconfig.html#cfn-amplify-app-basicauthconfig-enablebasicauth?

[mwiarda-fette]

Hi Adam, thanks for the feedback.
Unfortunately, we only have basic support.
I will contact our account manager. Maybe he would like to open a case.

Best,
Michael

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.