fix(amplify): deployment does not remove basic auth #15243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the `BasicAuthConfig` property from the template doesn't remove the basic auth. Explicitely set `EnableBasicAuth` to `false` instead. Closes aws#15028
|
|
skinny85
changed the title
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Seiya6329
pushed a commit
to Seiya6329/aws-cdk
that referenced
this pull request
Jun 22, 2021
Removing the `BasicAuthConfig` property from the template doesn't remove the basic auth. Explicitely set `EnableBasicAuth` to `false` instead. Closes aws#15028 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
matthewsvu
pushed a commit
to matthewsvu/aws-cdk
that referenced
this pull request
Jun 22, 2021
Removing the `BasicAuthConfig` property from the template doesn't remove the basic auth. Explicitely set `EnableBasicAuth` to `false` instead. Closes aws#15028 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
Removing the `BasicAuthConfig` property from the template doesn't remove the basic auth. Explicitely set `EnableBasicAuth` to `false` instead. Closes aws#15028 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the
BasicAuthConfigproperty from the template doesn't removethe basic auth. Explicitely set
EnableBasicAuthtofalseinstead.Closes #15028
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license