Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-eks): Cannot access default fargate profile for new FargateCluster #16149

Closed
2 tasks
magoun opened this issue Aug 20, 2021 · 2 comments · Fixed by #17130
Closed
2 tasks

(aws-eks): Cannot access default fargate profile for new FargateCluster #16149

magoun opened this issue Aug 20, 2021 · 2 comments · Fixed by #17130
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@magoun
Copy link

magoun commented Aug 20, 2021 •
edited
Loading

It would be useful to have a way to list all fargate profiles associated with a fargate cluster. Currently there isn't a way to access the default profile created by the FargateCluster construct.

Use Case

My specific case is to allow new FargateCluster to create a default fargate profile, then fetch the pod execution role from that profile and reuse it later when adding further profiles (via CI/CD pipeline).

Proposed Solution

Ideally, the fargate cluster class would have a fargateProfiles property that could be accessed. It was also work to be able to instantiated a FargateProfile class from a profile arn. That would only require the cluster to return the default profile arn as a property, instead of all profiles of the cluster.

A workaround is to explicitly create the default profile and pod execution role, then output the created execution role for use in the pipeline.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@magoun magoun added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 20, 2021
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Aug 20, 2021
@otaviomacedo otaviomacedo added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 24, 2021
@otaviomacedo
Copy link
Contributor

Hi, @magoun

Thanks for this feature request. It should be relatively simple to implement, since we already have the object inside FargateCluster:

aws-cdk/packages/@aws-cdk/aws-eks/lib/fargate-cluster.ts

Line 34 in 6a20e61

this.addFargateProfile(

It's just a matter of exposing it as a public readonly attribute (in addition to unit tests and documentation, of course). We can't work on this immediately, but if you are interested in submitting a PR, I'm happy to review it.

@otaviomacedo otaviomacedo added the good first issue Related to contributions. See CONTRIBUTING.md label Aug 24, 2021
@otaviomacedo otaviomacedo removed their assignment Aug 24, 2021
@kaylanm kaylanm mentioned this issue Oct 23, 2021
Merged
@mergify mergify bot closed this as completed in #17130 Nov 3, 2021
mergify bot pushed a commit that referenced this issue Nov 3, 2021
@kaylanm
feat(eks): expose FargateCluster's defaultProfile (#17130)
e461601 
Expose FargateCluster's defaultProfile.

Fixes #16149

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Nov 3, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@kaylanm @TikiTDO
feat(eks): expose FargateCluster's defaultProfile (aws#17130)
d889575 
Expose FargateCluster's defaultProfile.

Fixes aws#16149

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eks): expose FargateCluster's defaultProfile kaylanm/aws-cdk
2 participants
@otaviomacedo @magoun