Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): expose FargateCluster's defaultProfile #17130

Merged

Conversation

kaylanm
Copy link
Contributor

@kaylanm kaylanm commented Oct 23, 2021

Expose FargateCluster's defaultProfile.

Fixes #16149


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 23, 2021

@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Oct 23, 2021
@otaviomacedo
Copy link
Contributor

otaviomacedo commented Oct 23, 2021

Thanks. Can you please also mention this property in the Fargate profiles section of the README?

@kaylanm kaylanm force-pushed the feat/expose-fargatecluster-defaultprofile branch from 82995b3 to ab10530 Compare October 23, 2021 19:19
@otaviomacedo otaviomacedo added the pr-linter/exempt-test The PR linter will not require test changes label Oct 25, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c1943b5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e461601 into aws:master Nov 3, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@kaylanm kaylanm deleted the feat/expose-fargatecluster-defaultprofile branch November 4, 2021 12:52
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Expose FargateCluster's defaultProfile.

Fixes aws#16149

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-eks): Cannot access default fargate profile for new FargateCluster
3 participants