Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): expose FargateCluster's defaultProfile #17130

Merged
merged 2 commits into from
Nov 3, 2021
Merged

feat(eks): expose FargateCluster's defaultProfile #17130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab10530
feat(eks): expose FargateCluster's defaultProfile
kaylanm Oct 23, 2021
c1943b5
Merge branch 'master' into feat/expose-fargatecluster-defaultprofile
mergify[bot] Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-eks/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,8 @@ const cluster = new eks.FargateCluster(this, 'MyCluster', {
});
```

`FargateCluster` will create a default `FargateProfile` which can be accessed via the cluster's `defaultProfile` property. The created profile can also be customized by passing options as with `addFargateProfile`.

**NOTE**: Classic Load Balancers and Network Load Balancers are not supported on
pods running on Fargate. For ingress, we recommend that you use the [ALB Ingress
Controller](https://docs.aws.amazon.com/eks/latest/userguide/alb-ingress.html)
Expand Down
9 changes: 7 additions & 2 deletions packages/@aws-cdk/aws-eks/lib/fargate-cluster.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Construct } from 'constructs';
import { Cluster, ClusterOptions, CoreDnsComputeType } from './cluster';
import { FargateProfileOptions } from './fargate-profile';
import { FargateProfile, FargateProfileOptions } from './fargate-profile';

/**
* Configuration props for EKS Fargate.
Expand All @@ -23,6 +23,11 @@ export interface FargateClusterProps extends ClusterOptions {
* `addFargateProfile`.
*/
export class FargateCluster extends Cluster {
/**
* Fargate Profile that was created with the cluster.
*/
public readonly defaultProfile: FargateProfile;

constructor(scope: Construct, id: string, props: FargateClusterProps) {
super(scope, id, {
...props,
Expand All @@ -31,7 +36,7 @@ export class FargateCluster extends Cluster {
version: props.version,
});

this.addFargateProfile(
this.defaultProfile = this.addFargateProfile(
props.defaultProfile?.fargateProfileName ?? (props.defaultProfile ? 'custom' : 'default'),
props.defaultProfile ?? {
selectors: [
Expand Down