Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDKv2GA]: v2 Typescript/Javascript lib init template incorrect #16572

Closed
njlynch opened this issue Sep 21, 2021 · 1 comment · Fixed by #16577
Closed

[CDKv2GA]: v2 Typescript/Javascript lib init template incorrect #16572

njlynch opened this issue Sep 21, 2021 · 1 comment · Fixed by #16577
Assignees
@rix0rrr
Labels
aws-cdk-lib Related to the aws-cdk-lib package bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1 package/tools Related to AWS CDK Tools or CLI
Milestone
[GA] CDK V2

Comments

@njlynch
Copy link
Contributor

njlynch commented Sep 21, 2021

The template should instantiate a package.json where both aws-cdk-lib and constructs are "devDependencies" and "peerDependencies", not "dependencies".

Example (correct) config:

  "devDependencies": {
    "@types/jest": "^26.0.10",
    "@types/node": "10.17.27",
    "jest": "^26.4.2",
    "ts-jest": "^26.2.0",
    "typescript": "...",
    "aws-cdk-lib": "2.0.0-rc.21",
    "constructs": "^10.0.0"
  },
  "peerDependencies": {
    "aws-cdk-lib": "2.0.0-rc.21",
    "constructs": "^10.0.0"
  }
@njlynch njlynch added bug This issue is a bug. p1 package/tools Related to AWS CDK Tools or CLI effort/small Small work item – less than a day of effort labels Sep 21, 2021
@njlynch njlynch added this to the [GA] CDK V2 milestone Sep 21, 2021
@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label Sep 21, 2021
@njlynch njlynch changed the title [CDKv2GA]: v2 Typescript/Javascript lib template incorrect [CDKv2GA]: v2 Typescript/Javascript lib init template incorrect Sep 21, 2021
@njlynch njlynch assigned rix0rrr and unassigned nija-at Sep 21, 2021
rix0rrr added a commit that referenced this issue Sep 21, 2021
@rix0rrr
chore(init-templates): fix dependencies in v2 TypeScript templates
ff855c5 
We should not be using `dependencies` in libraries, but
`devDependencies` instead.

Fixes #16572.
@rix0rrr rix0rrr mentioned this issue Sep 21, 2021
Merged
njlynch pushed a commit that referenced this issue Sep 28, 2021
@rix0rrr @njlynch
chore(init-templates): fix dependencies in v2 TypeScript templates
52a04cc 
We should not be using `dependencies` in libraries, but
`devDependencies` instead.

Fixes #16572.
@njlynch njlynch added the in-progress This issue is being actively worked on. label Sep 28, 2021
@mergify mergify bot closed this as completed in #16577 Sep 30, 2021
mergify bot pushed a commit that referenced this issue Sep 30, 2021
@rix0rrr
chore(init-templates): fix dependencies in v2 TypeScript templates (#…
3a724a2 
…16577)

We should not be using `dependencies` in libraries, but
`devDependencies` instead.

Fixes #16572.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

njlynch pushed a commit that referenced this issue Oct 11, 2021
@rix0rrr @njlynch
chore(init-templates): fix dependencies in v2 TypeScript templates (#…
9f820a2 
…16577)

We should not be using `dependencies` in libraries, but
`devDependencies` instead.

Fixes #16572.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@rix0rrr @TikiTDO
chore(init-templates): fix dependencies in v2 TypeScript templates (a…
6133d56 
…ws#16577)

We should not be using `dependencies` in libraries, but
`devDependencies` instead.

Fixes aws#16572.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
aws-cdk-lib Related to the aws-cdk-lib package bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
[GA] CDK V2
Development

Successfully merging a pull request may close this issue.

chore(init-templates): fix dependencies in v2 TypeScript templates aws/aws-cdk
3 participants
@rix0rrr @njlynch @nija-at