Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(init-templates): fix dependencies in v2 TypeScript templates #16577

Merged
merged 5 commits into from
Sep 30, 2021
Merged

chore(init-templates): fix dependencies in v2 TypeScript templates #16577

merged 5 commits into from
Sep 30, 2021

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Sep 21, 2021

We should not be using dependencies in libraries, but
devDependencies instead.

Fixes #16572.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr requested a review from njlynch September 21, 2021 16:02
@rix0rrr rix0rrr self-assigned this Sep 21, 2021
@gitpod-io
Copy link

gitpod-io bot commented Sep 21, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 21, 2021
njlynch
njlynch suggested changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conforms to the current standards, but it's driving me nuts that our "v2" templates are showing constructs ^3 as the version, given that is never accurate.

I backported some changes in #16578. Can you approve that, and then re-base this on top of it?

@rix0rrr @njlynch
chore(init-templates): fix dependencies in v2 TypeScript templates
52a04cc 
We should not be using `dependencies` in libraries, but
`devDependencies` instead.

Fixes #16572.
@njlynch njlynch force-pushed the huijbers/fix-npm-init branch from ff855c5 to 52a04cc Compare September 28, 2021 16:13
njlynch
njlynch approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took the liberty of doing the rebase myself. :)

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@njlynch njlynch added this to the [GA] CDK V2 milestone Sep 30, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 415c540
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3a724a2 into master Sep 30, 2021
@mergify mergify bot deleted the huijbers/fix-npm-init branch September 30, 2021 13:59
@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

njlynch pushed a commit that referenced this pull request Oct 11, 2021
@rix0rrr @njlynch
chore(init-templates): fix dependencies in v2 TypeScript templates (#…
9f820a2 
…16577)

We should not be using `dependencies` in libraries, but
`devDependencies` instead.

Fixes #16572.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@rix0rrr @TikiTDO
chore(init-templates): fix dependencies in v2 TypeScript templates (a…
6133d56 
…ws#16577)

We should not be using `dependencies` in libraries, but
`devDependencies` instead.

Fixes aws#16572.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njlynch njlynch njlynch approved these changes

Assignees

@rix0rrr rix0rrr

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
[GA] CDK V2
Development

Successfully merging this pull request may close these issues.

[CDKv2GA]: v2 Typescript/Javascript lib init template incorrect
3 participants
@rix0rrr @aws-cdk-automation @njlynch