Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ecs): ServiceAttributes#fromServiceAtrributes is a typo #20458

Closed
dafujii opened this issue May 23, 2022 · 1 comment · Fixed by #20456
Closed

(ecs): ServiceAttributes#fromServiceAtrributes is a typo #20458

dafujii opened this issue May 23, 2022 · 1 comment · Fixed by #20456
Assignees
@madeline-k
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@dafujii
Copy link
Contributor

dafujii commented May 23, 2022

Describe the bug

packages/@aws-cdk/aws-ecs/lib/base/from-service-attributes.ts

ServiceAttributes have a method: fromServiceAtrributes

  1. But fromServiceAtrributes is a typo.

Expected Behavior

fromServiceAttributes

Current Behavior

fromServiceAtrributes

Reproduction Steps

Open packages/@aws-cdk/aws-ecs/lib/base/from-service-attributes.ts

Possible Solution

  1. rename fromServiceAtrributes from fromServiceAttributes
  2. create fromServiceAtrributes as a deprecated

Additional Information/Context

No response

CDK CLI Version

2.25.0

Framework Version

No response

Node.js Version

16.15.0

OS

Windows 10

Language

Typescript

Language Version

4.6.3

Other information

No response
@dafujii dafujii added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels May 23, 2022
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label May 23, 2022
@dafujii dafujii mentioned this issue May 23, 2022
Merged
4 tasks
@dafujii dafujii changed the title (ecs): ServiceAttributes.fromServiceAtrributes is a typo (ecs): ServiceAttributes#fromServiceAtrributes is a typo May 23, 2022
@peterwoodworth peterwoodworth added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels May 24, 2022
@mergify mergify bot closed this as completed in #20456 May 28, 2022
mergify bot pushed a commit that referenced this issue May 28, 2022
@dafujii
fix(ecs): fix typo from fromServiceAtrributes to fromServiceAttributes (
f4439ce 
#20456)

Fixed: #20458 

I found `fromServiceAtrributes`. I fixed to `fromServiceAttributes`

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madeline-k madeline-k

Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ecs): fix typo from fromServiceAtrributes to fromServiceAttributes
3 participants
@dafujii @peterwoodworth @madeline-k