Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): fix typo from fromServiceAtrributes to fromServiceAttributes #20456

Merged
merged 7 commits into from
May 28, 2022
Merged

fix(ecs): fix typo from fromServiceAtrributes to fromServiceAttributes #20456

merged 7 commits into from
May 28, 2022

Conversation

dafujii
Copy link
Contributor

@dafujii dafujii commented May 23, 2022

Fixed: #20458

I found fromServiceAtrributes. I fixed to fromServiceAttributes


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 23, 2022

@github-actions github-actions bot added the p2 label May 23, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team May 23, 2022 06:42
@cgarvis
Copy link
Contributor

cgarvis commented May 24, 2022

@dafujii thanks for the contribution. If you get a chance, could you fix the build?

@cgarvis cgarvis added the pr-linter/exempt-test The PR linter will not require test changes label May 24, 2022
@dafujii
Copy link
Contributor Author

dafujii commented May 25, 2022

Ok, I'll try to fix the build.

Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @dafujii! couple things

deprecated_apis.txt Outdated Show resolved Hide resolved
@mergify mergify bot dismissed peterwoodworth’s stale review May 26, 2022 14:14

Pull request has been modified.

Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mergify
Copy link
Contributor

mergify bot commented May 28, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 6107748
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f4439ce into aws:master May 28, 2022
@mergify
Copy link
Contributor

mergify bot commented May 28, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(ecs): ServiceAttributes#fromServiceAtrributes is a typo
4 participants