Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipelines: Allow specifying custom action role for S3SourceOptions #20556

Closed
1 of 2 tasks
lewtds opened this issue May 31, 2022 · 2 comments · Fixed by #20576
Closed
1 of 2 tasks

pipelines: Allow specifying custom action role for S3SourceOptions #20556

lewtds opened this issue May 31, 2022 · 2 comments · Fixed by #20576
Labels
@aws-cdk/pipelines CDK Pipelines library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p1

Comments

@lewtds
Copy link

lewtds commented May 31, 2022 •
edited
Loading

Describe the feature

CodePipelineSource.s3() currently doesn't allow any method to inject a custom role or modifying the auto-generated action role.

Use Case

This is needed, for example, to allow the source action to use KMS to decrypt the bucket.

Proposed Solution

Add an eventRole?: iam.IRole field to S3SourceOptions then pass it through to S3SourceAction.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.26.0

Environment details (OS name and version, etc.)

macOS 11.3.1
@lewtds lewtds added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 31, 2022
@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label May 31, 2022
@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 1, 2022

Sounds good. I would call the properly role.

@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p1 and removed needs-triage This issue or PR still needs to be triaged. labels Jun 1, 2022
@rix0rrr rix0rrr removed their assignment Jun 1, 2022
@daschaa daschaa mentioned this issue Jun 1, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #20576 Jun 2, 2022
mergify bot pushed a commit that referenced this issue Jun 2, 2022
@daschaa
feat(pipelines): pass role to s3 source action (#20576)
e2768e8 
Fixes #20556 

Implements the role property for the `S3Source`, which is being passed down to the underlying `S3SourceAction`.

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jun 2, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/pipelines CDK Pipelines library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pipelines): pass role to s3 source action daschaa/aws-cdk
2 participants
@rix0rrr @lewtds