feat(pipelines): pass role to s3 source action #20576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
effort/small
kaizencc
previously requested changes
Jun 1, 2022
packages/@aws-cdk/pipelines/lib/codepipeline/codepipeline-source.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/pipelines/lib/codepipeline/codepipeline-source.ts
Outdated
Show resolved
Hide resolved
…ce.ts Co-authored-by: Kaizen Conroy <36202692+kaizencc@users.noreply.github.com>
…ce.ts Co-authored-by: Kaizen Conroy <36202692+kaizencc@users.noreply.github.com>
|
@kaizencc The PR linter is failing because it wants a change in the README file. Imho this is not needed here, what do you think? |
kaizencc
added
pr-linter/exempt-readme
kaizencc
approved these changes
Jun 2, 2022
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20556
Implements the role property for the
S3Source, which is being passed down to the underlyingS3SourceAction.All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license