Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-config): Add support for eks-cluster-xxx-version managed rule in ManagedRuleIdentifiers class #21254

Closed
1 of 2 tasks
watany-dev opened this issue Jul 20, 2022 · 2 comments · Fixed by #21344
Closed
1 of 2 tasks

(aws-config): Add support for eks-cluster-xxx-version managed rule in ManagedRuleIdentifiers class #21254

watany-dev opened this issue Jul 20, 2022 · 2 comments · Fixed by #21344
Labels
@aws-cdk/aws-config Related to AWS Config effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@watany-dev
Copy link
Contributor

watany-dev commented Jul 20, 2022 •
edited
Loading

Describe the feature

Currently ManagedRuleIdentifiers doesn't support identifier for this managed rule

※At first glance, it seems that there are no ECR / ECS rules at all, but the issue will be large, so let's divide it once.

Use Case

I should be able to create these Rules through CDK higher level construct.

Proposed Solution

Add constant to packages/@aws-cdk/aws-config/lib/rule.ts

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

v2.33.0

Environment details (OS name and version, etc.)

in any environment
@watany-dev watany-dev added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 20, 2022
@github-actions github-actions bot added the @aws-cdk/aws-config Related to AWS Config label Jul 20, 2022
@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Jul 25, 2022
@rix0rrr rix0rrr removed their assignment Jul 25, 2022
@watany-dev
Copy link
Contributor Author

I'll try to take on this issue

watany-dev pushed a commit to watany-dev/aws-cdk that referenced this issue Jul 27, 2022
fix aws#21254 eks cluster complience check
4179b0c
@watany-dev watany-dev mentioned this issue Jul 27, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #21344 Jul 28, 2022
mergify bot pushed a commit that referenced this issue Jul 28, 2022
@watany-dev
feat(config): add support for eks-cluster-xxx-version managed rule (#…
82e8100 
…21344)

fixes #21254 

The original issue was that Currently [ManagedRuleIdentifiers](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-config.ManagedRuleIdentifiers.html) doesn't support identifier for this managed rule
- eks-cluster-supported-version([EKS_CLUSTER_SUPPORTED_VERSION](https://docs.aws.amazon.com/config/latest/developerguide/eks-cluster-supported-version.html))
- eks-cluster-oldest-version eks-cluster-oldest-supported-version([EKS_CLUSTER_OLDEST_SUPPORTED_VERSION](https://docs.aws.amazon.com/config/latest/developerguide/eks-cluster-oldest-supported-version.html))

To solve this problem, it was necessary to define identifiers and type information to L2 Constructs.
- Add the following missing identifiers to `ManagedRuleIdentifiers`.
    - EKS_CLUSTER_OLDEST_SUPPORTED_VERSION
    - EKS_CLUSTER_SUPPORTED_VERSION
- Add the following missing types in `ResourceType`
    - AWS::EKS::Cluster
- and test code for these identifiers and types to work

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

josephedward pushed a commit to josephedward/aws-cdk that referenced this issue Aug 30, 2022
@watany-dev @josephedward
feat(config): add support for eks-cluster-xxx-version managed rule (a…
84c63cf 
…ws#21344)

fixes aws#21254 

The original issue was that Currently [ManagedRuleIdentifiers](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-config.ManagedRuleIdentifiers.html) doesn't support identifier for this managed rule
- eks-cluster-supported-version([EKS_CLUSTER_SUPPORTED_VERSION](https://docs.aws.amazon.com/config/latest/developerguide/eks-cluster-supported-version.html))
- eks-cluster-oldest-version eks-cluster-oldest-supported-version([EKS_CLUSTER_OLDEST_SUPPORTED_VERSION](https://docs.aws.amazon.com/config/latest/developerguide/eks-cluster-oldest-supported-version.html))

To solve this problem, it was necessary to define identifiers and type information to L2 Constructs.
- Add the following missing identifiers to `ManagedRuleIdentifiers`.
    - EKS_CLUSTER_OLDEST_SUPPORTED_VERSION
    - EKS_CLUSTER_SUPPORTED_VERSION
- Add the following missing types in `ResourceType`
    - AWS::EKS::Cluster
- and test code for these identifiers and types to work

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-config Related to AWS Config effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(config): add support for eks-cluster-xxx-version managed rule watany-dev/aws-cdk
2 participants
@rix0rrr @watany-dev