Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): add support for eks-cluster-xxx-version managed rule #21344

Merged
merged 2 commits into from
Jul 28, 2022
Merged

feat(config): add support for eks-cluster-xxx-version managed rule #21344

merged 2 commits into from
Jul 28, 2022

Conversation

watany-dev
Copy link
Contributor

@watany-dev watany-dev commented Jul 27, 2022 •
edited
Loading

fixes #21254

The original issue was that Currently ManagedRuleIdentifiers doesn't support identifier for this managed rule

To solve this problem, it was necessary to define identifiers and type information to L2 Constructs.

  • Add the following missing identifiers to ManagedRuleIdentifiers.
    • EKS_CLUSTER_OLDEST_SUPPORTED_VERSION
    • EKS_CLUSTER_SUPPORTED_VERSION
  • Add the following missing types in ResourceType
    • AWS::EKS::Cluster
  • and test code for these identifiers and types to work

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 27, 2022

@github-actions github-actions bot added the p2 label Jul 27, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team July 27, 2022 16:41
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. labels Jul 27, 2022
@TheRealAmazonKendra TheRealAmazonKendra changed the title fix(config): eks cluster complience check feat(config): add support for eks-cluster-xxx-version managed rule Jul 28, 2022
@TheRealAmazonKendra TheRealAmazonKendra added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jul 28, 2022
TheRealAmazonKendra
TheRealAmazonKendra requested changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that your PR body describes the problem the PR is solving, and the design approach and alternatives considered. Explain why the PR solves the problem. A link to an issue is helpful, but does not replace an explanation of your thought process (See Contributing Guide, Pull Requests)

@watany-dev
Copy link
Contributor Author

@TheRealAmazonKendra
Our apologies. We have reviewed the text and revised the explanation to clarify the intent and the section addressed. Thank you very much for your help in pointing this out in a way that is easy to understand.

@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 52936da
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 82e8100 into aws:main Jul 28, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@watany-dev watany-dev deleted the fix(21254)-nonManagedRuleEks branch July 28, 2022 23:47
josephedward pushed a commit to josephedward/aws-cdk that referenced this pull request Aug 30, 2022
@watany-dev @josephedward
feat(config): add support for eks-cluster-xxx-version managed rule (a…
84c63cf 
…ws#21344)

fixes aws#21254 

The original issue was that Currently [ManagedRuleIdentifiers](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-config.ManagedRuleIdentifiers.html) doesn't support identifier for this managed rule
- eks-cluster-supported-version([EKS_CLUSTER_SUPPORTED_VERSION](https://docs.aws.amazon.com/config/latest/developerguide/eks-cluster-supported-version.html))
- eks-cluster-oldest-version eks-cluster-oldest-supported-version([EKS_CLUSTER_OLDEST_SUPPORTED_VERSION](https://docs.aws.amazon.com/config/latest/developerguide/eks-cluster-oldest-supported-version.html))

To solve this problem, it was necessary to define identifiers and type information to L2 Constructs.
- Add the following missing identifiers to `ManagedRuleIdentifiers`.
    - EKS_CLUSTER_OLDEST_SUPPORTED_VERSION
    - EKS_CLUSTER_SUPPORTED_VERSION
- Add the following missing types in `ResourceType`
    - AWS::EKS::Cluster
- and test code for these identifiers and types to work

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra approved these changes

Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-config): Add support for eks-cluster-xxx-version managed rule in ManagedRuleIdentifiers class
3 participants
@watany-dev @aws-cdk-automation @TheRealAmazonKendra