aws-backup: Attribute BackupVault.props.backupVaultName fails a validation when used with parameters

[igormukhin]

Describe the bug

Trying to put a CF-parameter into the name of backup vault fails.

Expected Behavior

should run (allow the usage of tokens/parameters)

Current Behavior

fails with:

Error: Expected vault name to match pattern `^[a-zA-Z0-9-_]{2,50}$`
    at new BackupVault (D:\Sources\HRAR\iac\node_modules\aws-cdk-lib\aws-backup\lib\vault.js:1:2076)
    ...

Reproduction Steps

Run:

const stage = new CfnParameter(this, 'Stage', { type: 'String', description: 'Stage' });

new backup.BackupVault(this, 'BackupVault', {
    backupVaultName: `backupVault-${stage.valueAsString}`
});

Possible Solution

Remove the regEx validation from https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-backup/lib/vault.ts:264

if (props.backupVaultName && !/^[a-zA-Z0-9\-_]{2,50}$/.test(props.backupVaultName)) {
  throw new Error('Expected vault name to match pattern `^[a-zA-Z0-9\-_]{2,50}$`');
}

I think the validation is misplaced here, because it should support expressions like bla-${Token[TOKEN.285]}-bla.

Additional Information/Context

No response

CDK CLI Version

2.38.1 (build a5ced21)

Framework Version

2.38.1

Node.js Version

v16.15.1

OS

Windows 10

Language

Typescript

Language Version

4.7.4

Other information

No response

[igormukhin]

Workaround:

const stage = new CfnParameter(this, 'Stage', { type: 'String', description: 'Stage' });

new backup.BackupVault(this, 'BackupVault', {
    backupVaultName: `WILL-REPLACE-BELOW`
});

const cfnBackupVault = backupVault.node.findChild('Resource') as backup.CfnBackupVault;
cfnBackupVault.backupVaultName = `backupVault-${stage.valueAsString}`;

[kaizencc]

Whoops the validation needs to check if there is a token inside before running the regex. Something like if:

if (props.backupVaultName && !Token.isUnresolved(props.backupVaultName) && ...) {
  validate
}

[heyosi]

Hi @kaizencc , I want to fix this issue, could you assign to me?

[tam0ri]

Previous PR was automatically closed, so I newly submitted PR.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.